1604198 - Top Sites on multiple rows are displayed on one row under 1122px browser width

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Valentina Virlics [:vvalentina], Ecosystem QA]

[Affected Versions]:

• Firefox Nightly 73.0a1 (Build ID 20191215214948)

[Affected Platforms]:

• Win 10
• Mac 10.14
• Linux Debian 9

[Steps to reproduce]:

1. Open about:preferences#home page.
2. In Firefox Home Content section set Top Sites to be listed on 2 rows.
3. Open a new tab page.
4. Resize the browser to 1121 width.
5. Observe Top Sites section.

[Expected results]:
Top Sites section is displayed on 2 rows.

[Actual results]:
Top Sites section is displayed on 1 row.

[Additional notes]:

• Under 1121px browser width Top Sites are displayed in 1 row, no matter how is set in about:preferences#home page.
• Over 1121px browser width Top Sites are displayed as set in about:preferences#home page.
• Issue is not reproducible with Discovery Stream disabled.
• Issue is not reproducible for Highlights section.

Comment 3

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Raising the severity to critical based on the multiple reports we've got up to this point and the fact that we're planning on turning on DS for the rest of the world.

Comment 4

[Scott [:thecount] Downe]

I strongly suspect this is caused by https://bugzilla.mozilla.org/show_bug.cgi?id=1594537

Comment 5

[westsonoma]

(In reply to Scott [:thecount] Downe from comment #4)

I strongly suspect this is caused by https://bugzilla.mozilla.org/show_bug.cgi?id=1594537

That is what I came uo with when I checked with mozregression,

https://bugzilla.mozilla.org/show_bug.cgi?id=1605056

Comment 6

[Scott [:thecount] Downe]

I think I got a fix.

Comment 7

[Scott [:thecount] Downe]

To test:

1. Ensure Discovery Stream is on.
2. Set to 1 row of topsites.
3. Check all breakpoints.
4. Ensure you always have 1 row of topsites in first and second breakpoint, and ensure all rows are always of equal length.
5. The smaller breakpoints might have more rows, but should at least be of equal length of other rows.

Do steps 2-5 again with 2 rows of topsites, and again with 3 rows of topsites, then with 4.

Comment 8

[Scott [:thecount] Downe]

Attachment: Bug 1604198 - Multiple topsite rows with Discovery Stream and responsive design.

Comment 9

[Scott [:thecount] Downe]

Gavin, I got a fix pushed up and assigned to you for review.

I think the old Topsites css has coverage for our case, so I think if we delete the right css overrides, the old css we need covers this.

Let me know if you can find issues with this strategy.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b69c49bc5500
Multiple topsite rows with Discovery Stream and responsive design. r=gvn

Comment 11

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b69c49bc5500

Comment 12

[Andreea Cupsa [:acupsa], Experiments QA]

I have verified that this issue is no longer reproducible with the steps provided in the Steps to Reproduce section and the ones from Comment 7 on Firefox Nightly 73.0a1 (Build ID: 20191229212642) on Windows 10 x64, Mac 10.14.6 and Ubuntu 18.04.2.