1604223 - devtools/client/debugger/new/src/test/mochitest/browser.ini path breaks ./mach try --preset devtools

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I'm not sure who should own this one.

Bug 1545054 introduces a new preset for try that makes it easier to run relevant DevTools test suites without having to remember the names of the subsuites.

The actual command to execute is ./mach try --preset devtools

It breaks because a path is incorrect:
<srcdir>/devtools/client/debugger/node_modules/devtools-mc-assets/assets/devtools/client/debugger/new/src/test/mochitest/browser.ini (for some reason mach doesn't include the src folder).

You can work around this using:
rm -rf <srcdir>/devtools/client/debugger/node_modules/*

The details of the failure are as follows:

IOError: Missing files: <srcdir>/devtools/client/debugger/node_modules/devtools-mc-assets/assets/devtools/client/debugger/new/test/mochitest/browser.ini

  File "<srcdir>/tools/tryselect/mach_commands.py", line 211, in try_default
    'try', subcommand=sub, context=self._mach_context, argv=argv, **kwargs)
  File "<srcdir>/python/mach/mach/registrar.py", line 152, in dispatch
    return self._run_command_handler(handler, context=context, **kwargs)
  File "<srcdir>/python/mach/mach/registrar.py", line 109, in _run_command_handler
    result = fn(**kwargs)
  File "<srcdir>/tools/tryselect/mach_commands.py", line 312, in try_fuzzy
    return self.run(**kwargs)
  File "<srcdir>/tools/tryselect/mach_commands.py", line 182, in run
    return mod.run(**kwargs)
  File "<srcdir>/tools/tryselect/selectors/fuzzy.py", line 383, in run
    tg = generate_tasks(parameters, full)
  File "<srcdir>/tools/tryselect/tasks.py", line 107, in generate_tasks
    tg_full = generate('full_task_set')
  File "<srcdir>/tools/tryselect/tasks.py", line 97, in generate
    tg = getattr(generator, attr)
  File "<srcdir>/taskcluster/taskgraph/generator.py", line 141, in full_task_set
    return self._run_until('full_task_set')
  File "<srcdir>/taskcluster/taskgraph/generator.py", line 354, in _run_until
    k, v = self._run.next()
  File "<srcdir>/taskcluster/taskgraph/generator.py", line 263, in _run
    new_tasks = kind.load_tasks(parameters, list(all_tasks.values()))
  File "<srcdir>/taskcluster/taskgraph/generator.py", line 77, in load_tasks
    for task_dict in transforms(trans_config, inputs)]
  File "<srcdir>/taskcluster/taskgraph/transforms/task.py", line 2071, in check_run_task_caches
    for task in tasks:
  File "<srcdir>/taskcluster/taskgraph/transforms/task.py", line 2012, in check_task_dependencies
    for task in tasks:
  File "<srcdir>/taskcluster/taskgraph/transforms/task.py", line 2000, in check_task_identifiers
    for task in tasks:
  File "<srcdir>/taskcluster/taskgraph/transforms/task.py", line 1983, in chain_of_trust
    for task in tasks:
  File "<srcdir>/taskcluster/taskgraph/transforms/task.py", line 1821, in build_task
    for task in tasks:
  File "<srcdir>/taskcluster/taskgraph/transforms/task.py", line 1813, in try_task_config_chemspill_prio
    for task in tasks:
  File "<srcdir>/taskcluster/taskgraph/transforms/task.py", line 1803, in try_task_config_env
    for task in tasks:
  File "<srcdir>/taskcluster/taskgraph/transforms/task.py", line 1768, in add_index_routes
    for task in tasks:
  File "<srcdir>/taskcluster/taskgraph/transforms/task.py", line 1502, in validate
    for task in tasks:
  File "<srcdir>/taskcluster/taskgraph/transforms/task.py", line 1479, in task_name_from_label
    for task in tasks:
  File "<srcdir>/taskcluster/taskgraph/transforms/task.py", line 1439, in set_defaults
    for task in tasks:
  File "<srcdir>/taskcluster/taskgraph/transforms/task.py", line 1418, in set_implementation
    for task in tasks:
  File "<srcdir>/taskcluster/taskgraph/transforms/coalesce.py", line 30, in enable_coalescing
    for job in jobs:
  File "<srcdir>/taskcluster/taskgraph/transforms/job/__init__.py", line 309, in make_task_description
    for job in jobs:
  File "<srcdir>/taskcluster/taskgraph/transforms/job/__init__.py", line 200, in use_fetches
    for job in order_tasks(config, jobs):
  File "<srcdir>/taskcluster/taskgraph/transforms/cached_tasks.py", line 22, in order_tasks
    pending = deque(tasks)
  File "<srcdir>/taskcluster/taskgraph/transforms/job/__init__.py", line 155, in set_label
    for job in jobs:
  File "<srcdir>/taskcluster/taskgraph/transforms/job/__init__.py", line 139, in set_implementation
    for job in jobs:
  File "<srcdir>/taskcluster/taskgraph/transforms/job/__init__.py", line 119, in rewrite_when_to_optimization
    for job in jobs:
  File "<srcdir>/taskcluster/taskgraph/transforms/base.py", line 75, in __call__
    for task in tasks:
  File "<srcdir>/taskcluster/taskgraph/transforms/tests.py", line 1568, in make_job_description
    for test in tests:
  File "<srcdir>/taskcluster/taskgraph/transforms/tests.py", line 1506, in set_worker_type
    for test in tests:
  File "<srcdir>/taskcluster/taskgraph/transforms/tests.py", line 1492, in single_stylo_traversal_tests
    for test in tests:
  File "<srcdir>/taskcluster/taskgraph/transforms/tests.py", line 1481, in set_test_type
    for test in tests:
  File "<srcdir>/taskcluster/taskgraph/transforms/tests.py", line 1473, in set_tag
    for test in tests:
  File "<srcdir>/taskcluster/taskgraph/transforms/tests.py", line 1461, in set_profile
    for test in tests:
  File "<srcdir>/taskcluster/taskgraph/transforms/tests.py", line 1447, in set_retry_exit_status
    for test in tests:
  File "<srcdir>/taskcluster/taskgraph/transforms/tests.py", line 1436, in set_schedules_for_webrender_android
    for test in tests:
  File "<srcdir>/taskcluster/taskgraph/transforms/tests.py", line 1422, in enable_webrender
    for test in tests:
  File "<srcdir>/taskcluster/taskgraph/transforms/tests.py", line 1407, in allow_software_gl_layers
    for test in tests:
  File "<srcdir>/taskcluster/taskgraph/transforms/tests.py", line 1375, in split_chunks
    test['chunks'],
  File "<srcdir>/python/mozbuild/mozbuild/util.py", line 988, in __call__
    self[args] = self.func(*args)
  File "<srcdir>/taskcluster/taskgraph/transforms/tests.py", line 1340, in get_chunked_manifests
    tests = get_tests(flavor, subsuite)
  File "<srcdir>/python/mozbuild/mozbuild/util.py", line 988, in __call__
    self[args] = self.func(*args)
  File "<srcdir>/taskcluster/taskgraph/transforms/tests.py", line 1336, in get_tests
    return list(resolver.resolve_tests(flavor=flavor, subsuite=subsuite))
  File "<srcdir>/testing/mozbase/moztest/moztest/resolve.py", line 741, in resolve_tests
    for test in self._resolve(**kwargs):
  File "<srcdir>/testing/mozbase/moztest/moztest/resolve.py", line 565, in _resolve
    candidate_paths |= set(self.tests_by_path.keys())
  File "<srcdir>/testing/mozbase/moztest/moztest/resolve.py", line 508, in tests_by_path
    for test in self.tests:
  File "<srcdir>/testing/mozbase/moztest/moztest/resolve.py", line 500, in tests
    for test in self.load_tests():
  File "<srcdir>/testing/mozbase/moztest/moztest/resolve.py", line 452, in __call__
    tests = self._load_manifestparser_manifest(mpath)
  File "<srcdir>/testing/mozbase/moztest/moztest/resolve.py", line 432, in _load_manifestparser_manifest
    finder=self.finder, handle_defaults=True)
  File "<srcdir>/testing/mozbase/manifestparser/manifestparser/manifestparser.py", line 796, in __init__
    ManifestParser.__init__(self, *args, **kwargs)
  File "<srcdir>/testing/mozbase/manifestparser/manifestparser/manifestparser.py", line 87, in __init__
    self.read(*manifests)
  File "<srcdir>/testing/mozbase/manifestparser/manifestparser/manifestparser.py", line 276, in read
    raise IOError('Missing files: %s' % ', '.join(missing))

Comment 1

[Jason Laster [:jlast]]

Attachment: Bug 1604223 - fix ./mach try --preset devtools. r=nchevobbe

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a1f3325a46a
fix ./mach try --preset devtools. r=nchevobbe

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/9a1f3325a46a