1604299 - Sort out existing references to XULDocument in our code

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

https://searchfox.org/mozilla-central/search?q=XULDocument&case=true

• The orderfile bits can just go away.
• I'm not sure what devtools is doing and why; needs investigation.
• The comments presumably no longer need to refer to XULDocument, since it's gone.
• The canvas test may be able to be simplified, though maybe upstream?

Comment 1

[Brian Grinstead [:bgrins]]

(In reply to Boris Zbarsky [:bzbarsky, bz on IRC] from comment #0)

• I'm not sure what devtools is doing and why; needs investigation.

Julian just asked about the result in actors/inspector/inspector.js in https://bugzilla.mozilla.org/show_bug.cgi?id=1604126#c3 - I believe that one should go away.

The other DevTools check could probably just be changed to check system principal here https://searchfox.org/mozilla-central/rev/c61720a7d0c094d772059f9d6a7844eb7619f107/devtools/server/actors/inspector/utils.js#160-165. I'd have to double check but I think that condition was needed for something related to XBL (Bug 1187482) and I also don't remember why we went with "xul document" and not "chrome document" in the first place.

Comment 2

[Emma Malysz]

Attachment: Bug 1604299, Remove remaining references to XULDocument

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b33ee7e44a88
Remove remaining references to XULDocument r=bgrins

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b33ee7e44a88