1604447 - (diversion-goodbye) [meta] Remove data "diversion" code from channels

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Honza Bambas (:mayhemer)]

As DocumentChannel now allows content decisions for navigational requests to happen fully on the parent process, we are getting to a point to fully remove the "diversion" hacky code at [1] and [2] for http and ftp.

This is a meta to track the work.

[1] https://searchfox.org/mozilla-central/rev/c61720a7d0c094d772059f9d6a7844eb7619f107/netwerk/protocol/http/PHttpChannel.ipdl#76,81,84
[2] https://searchfox.org/mozilla-central/rev/c61720a7d0c094d772059f9d6a7844eb7619f107/netwerk/protocol/ftp/PFTPChannel.ipdl#34,39,42

Comment 2

[Sonakshi Saxena]

(In reply to Honza Bambas (:mayhemer) from comment #0)

As DocumentChannel now allows content decisions for navigational requests to happen fully on the parent process, we are getting to a point to fully remove the "diversion" hacky code at [1] and [2] for http and ftp.

This is a meta to track the work.

[1] https://searchfox.org/mozilla-central/rev/c61720a7d0c094d772059f9d6a7844eb7619f107/netwerk/protocol/http/PHttpChannel.ipdl#76,81,84
[2] https://searchfox.org/mozilla-central/rev/c61720a7d0c094d772059f9d6a7844eb7619f107/netwerk/protocol/ftp/PFTPChannel.ipdl#34,39,42

Hey Honza
I would like to take this up.
Thanks :)

Comment 3

[Honza Bambas (:mayhemer)]

Thanks for offering to help with this, but I have to say "no." This is a metabug covering a larger project that is not a priority and is dependent on stabilization of the DocumentChannel feature, which has landed only recently.

Comment 4

[Sonakshi Saxena]

Attachment: Bug 1604447 - Remove data diversion code from channels

Comment 5

[Sonakshi Saxena]

(In reply to Honza Bambas (:mayhemer) from comment #3)

Thanks for offering to help with this, but I have to say "no." This is a metabug covering a larger project that is not a priority and is dependent on stabilization of the DocumentChannel feature, which has landed only recently.

Oh I'm sorry! I had completed this, and didn't see your reply. Should I abandon the patch?

Comment 6

[Honza Bambas (:mayhemer)]

(In reply to Sonakshi Saxena from comment #5)

Should I abandon the patch?

No need, keep it, just remove the reviewers.

Comment 7

[Sonakshi Saxena]

Sure. Apologies!

Comment 8

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1604447 - Remove channel diversion code. r?dragana!

Depends on D90192

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cb12ccee75a
Remove channel diversion code. r=dragana,necko-reviewers

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 3cb12ccee75a (bug 1604447) for causing build bustage.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&fromchange=963f87c25ddf0acf529d26f8dd0c90bf638eb3a1&searchStr=build&tochange=15aeeeb2ff1fb2c2abeb4f2ff4a4642857e9d8d2&selectedTaskRun=eiIADyJdS-iKengvNOMeyQ.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/ee24ac0d26cb57db6e15b2380ec11a8dd5c3b85c

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316113059&repo=autoland&lineNumber=23476

[task 2020-09-18T20:29:19.705Z] 20:29:19     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/ipc/ipdl'
[task 2020-09-18T20:29:19.705Z] 20:29:19     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang-cl -Xclang -std=c++17 -m32 -FoUnifiedProtocols25.obj -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -guard:cf -DNDEBUG=1 -DTRIMMED=1 -DUNICODE -D_UNICODE -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DOS_WIN=1 -DWIN32 -D_WIN32 -D_WINDOWS -DWIN32_LEAN_AND_MEAN -DCOMPILER_MSVC -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/ipc/ipdl -I/builds/worker/workspace/obj-build/ipc/ipdl -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -MD -FI /builds/worker/workspace/obj-build/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -Qunused-arguments -fcrash-diagnostics-dir=/builds/worker/artifacts -TP -Zc:sizedDealloc- -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -arch:SSE2 -Gw -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-microsoft-exception-spec -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -Werror -Xclang -fexperimental-new-pass-manager  -Xclang -MP -Xclang -dependency-file -Xclang .deps/UnifiedProtocols25.obj.pp -Xclang -MT -Xclang UnifiedProtocols25.obj   UnifiedProtocols25.cpp
[task 2020-09-18T20:29:19.705Z] 20:29:19     INFO -  In file included from UnifiedProtocols25.cpp:2:
[task 2020-09-18T20:29:19.705Z] 20:29:19     INFO -  In file included from /builds/worker/workspace/obj-build/ipc/ipdl/PProxyConfigLookup.cpp:7:
[task 2020-09-18T20:29:19.705Z] 20:29:19     INFO -  In file included from /builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders/mozilla/net/PSocketProcessParent.h:9:
[task 2020-09-18T20:29:19.705Z] 20:29:19     INFO -  In file included from /builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders/mozilla/net/PSocketProcess.h:11:
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/ipc/IPCMessageUtils.h:11:
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  In file included from /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_message_utils.h:27:
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  In file included from /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_message.h:14:
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h(49,37): error: member access into incomplete type 'mozilla::layers::IGPUVideoSurfaceManager'
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -    static void AddRef(U* aPtr) { aPtr->AddRef(); }
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -                                      ^
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h(380,61): note: in instantiation of member function 'mozilla::RefPtrTraits<mozilla::layers::IGPUVideoSurfaceManager>::AddRef' requested here
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -      static void AddRef(U* aPtr) { mozilla::RefPtrTraits<U>::AddRef(aPtr); }
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -                                                              ^
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h(109,37): note: in instantiation of member function 'RefPtr<mozilla::layers::IGPUVideoSurfaceManager>::ConstRemovingRefPtrTraits<mozilla::layers::IGPUVideoSurfaceManager>::AddRef' requested here
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -        ConstRemovingRefPtrTraits<T>::AddRef(mRawPtr);
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -                                      ^
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/RemoteImageHolder.h(34,9): note: in instantiation of member function 'RefPtr<mozilla::layers::IGPUVideoSurfaceManager>::RefPtr' requested here
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -          mManager(aManager),
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -          ^
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/RemoteImageHolder.h(19,7): note: forward declaration of 'mozilla::layers::IGPUVideoSurfaceManager'
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  class IGPUVideoSurfaceManager;
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -        ^
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  In file included from UnifiedProtocols25.cpp:2:
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  In file included from /builds/worker/workspace/obj-build/ipc/ipdl/PProxyConfigLookup.cpp:7:
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  In file included from /builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders/mozilla/net/PSocketProcessParent.h:9:
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  In file included from /builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders/mozilla/net/PSocketProcess.h:11:
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/ipc/IPCMessageUtils.h:11:
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  In file included from /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_message_utils.h:27:
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  In file included from /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_message.h:14:
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h(50,38): error: member access into incomplete type 'mozilla::layers::IGPUVideoSurfaceManager'
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -    static void Release(U* aPtr) { aPtr->Release(); }
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -                                       ^
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h(381,62): note: in instantiation of member function 'mozilla::RefPtrTraits<mozilla::layers::IGPUVideoSurfaceManager>::Release' requested here
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -      static void Release(U* aPtr) { mozilla::RefPtrTraits<U>::Release(aPtr); }
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -                                                               ^
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h(81,37): note: in instantiation of member function 'RefPtr<mozilla::layers::IGPUVideoSurfaceManager>::ConstRemovingRefPtrTraits<mozilla::layers::IGPUVideoSurfaceManager>::Release' requested here
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -        ConstRemovingRefPtrTraits<T>::Release(mRawPtr);
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -                                      ^
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/RemoteImageHolder.h(27,3): note: in instantiation of member function 'RefPtr<mozilla::layers::IGPUVideoSurfaceManager>::~RefPtr' requested here
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -    RemoteImageHolder(layers::IGPUVideoSurfaceManager* aManager,
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -    ^
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/RemoteImageHolder.h(19,7): note: forward declaration of 'mozilla::layers::IGPUVideoSurfaceManager'
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  class IGPUVideoSurfaceManager;
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -        ^
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  2 errors generated.
[task 2020-09-18T20:29:19.706Z] 20:29:19    ERROR -  make[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:725: UnifiedProtocols25.obj] Error 1
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/ipc/ipdl'
[task 2020-09-18T20:29:19.706Z] 20:29:19     INFO -  make[4]: *** Waiting for unfinished jobs....
[task 2020-09-18T20:29:19.707Z] 20:29:19     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/gfx/layers'

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/422f5664c317
Remove channel diversion code. r=dragana,necko-reviewers

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/422f5664c317