1665945 - "error: member access into incomplete type 'mozilla::layers::IGPUVideoSurfaceManager" build bustage with --disable-accessibility

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/logviewer.html#?job_id=316085614&repo=try

In file included from UnifiedProtocols25.cpp:2:
In file included from /builds/worker/workspace/obj-build/ipc/ipdl/PProxyConfigLookup.cpp:7:
In file included from /builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders/mozilla/net/PSocketProcessParent.h:9:
In file included from /builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders/mozilla/net/PSocketProcess.h:11:
In file included from /builds/worker/workspace/obj-build/dist/include/ipc/IPCMessageUtils.h:11:
In file included from /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_message_utils.h:27:
In file included from /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_message.h:14:
/builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h(49,37): error: member access into incomplete type 'mozilla::layers::IGPUVideoSurfaceManager'
  static void AddRef(U* aPtr) { aPtr->AddRef(); }
                                    ^
/builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h(380,61): note: in instantiation of member function 'mozilla::RefPtrTraits<mozilla::layers::IGPUVideoSurfaceManager>::AddRef' requested here
    static void AddRef(U* aPtr) { mozilla::RefPtrTraits<U>::AddRef(aPtr); }
                                                            ^
/builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h(109,37): note: in instantiation of member function 'RefPtr<mozilla::layers::IGPUVideoSurfaceManager>::ConstRemovingRefPtrTraits<mozilla::layers::IGPUVideoSurfaceManager>::AddRef' requested here
      ConstRemovingRefPtrTraits<T>::AddRef(mRawPtr);
                                    ^
/builds/worker/workspace/obj-build/dist/include/mozilla/RemoteImageHolder.h(34,9): note: in instantiation of member function 'RefPtr<mozilla::layers::IGPUVideoSurfaceManager>::RefPtr' requested here
        mManager(aManager),
        ^
/builds/worker/workspace/obj-build/dist/include/mozilla/RemoteImageHolder.h(19,7): note: forward declaration of 'mozilla::layers::IGPUVideoSurfaceManager'
class IGPUVideoSurfaceManager;
      ^
In file included from UnifiedProtocols25.cpp:2:
In file included from /builds/worker/workspace/obj-build/ipc/ipdl/PProxyConfigLookup.cpp:7:
In file included from /builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders/mozilla/net/PSocketProcessParent.h:9:
In file included from /builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders/mozilla/net/PSocketProcess.h:11:
In file included from /builds/worker/workspace/obj-build/dist/include/ipc/IPCMessageUtils.h:11:
In file included from /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_message_utils.h:27:
In file included from /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_message.h:14:
/builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h(50,38): error: member access into incomplete type 'mozilla::layers::IGPUVideoSurfaceManager'
  static void Release(U* aPtr) { aPtr->Release(); }
                                     ^
/builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h(381,62): note: in instantiation of member function 'mozilla::RefPtrTraits<mozilla::layers::IGPUVideoSurfaceManager>::Release' requested here
    static void Release(U* aPtr) { mozilla::RefPtrTraits<U>::Release(aPtr); }
                                                             ^
/builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h(81,37): note: in instantiation of member function 'RefPtr<mozilla::layers::IGPUVideoSurfaceManager>::ConstRemovingRefPtrTraits<mozilla::layers::IGPUVideoSurfaceManager>::Release' requested here
      ConstRemovingRefPtrTraits<T>::Release(mRawPtr);
                                    ^
/builds/worker/workspace/obj-build/dist/include/mozilla/RemoteImageHolder.h(27,3): note: in instantiation of member function 'RefPtr<mozilla::layers::IGPUVideoSurfaceManager>::~RefPtr' requested here
  RemoteImageHolder(layers::IGPUVideoSurfaceManager* aManager,
  ^
/builds/worker/workspace/obj-build/dist/include/mozilla/RemoteImageHolder.h(19,7): note: forward declaration of 'mozilla::layers::IGPUVideoSurfaceManager'
class IGPUVideoSurfaceManager;
      ^
2 errors generated.

Note that to reproduce this issue locally, you'll need to apply the patch attached to bug 1665160 to work around that build bustage :).

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1665945 - Fix compilation. r?gerald

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1aad6539812f
Fix compilation. r=gerald

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1aad6539812f