Closed Bug 1604458 Opened 3 years ago Closed 3 years ago

Incorrent mark for a multicopy

Categories

(Conduit :: moz-phab, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zalun, Assigned: zalun)

References

Details

(Keywords: conduit-triaged)

Attachments

(1 file)

Steps to reproduce a copy error (on a dev site):

$  hg clone https://hg.mozilla.org/automation/phabricator-qa-dev/ 
$ hg copy TEST TEST-copied
$ hg move TEST TEST-moved
$ hg commit -m "Bug 1 - multicopy"
$ moz-phab --no-arc --yes . 

Expected (created with arc - moz-phab --yes .):

TEST  This file was deleted after being copied to TEST-copied, TEST-mved.
TEST-copied  This file was moved from TEST.
TEST-moved  This file was copied from TEST.
                          ^^^^^^

Actual:

TEST  This file was deleted after being copied to TEST-copied, TEST-mved.
TEST-copied  This file was moved from TEST.
TEST-moved  This file was moved from TEST.
                          ^^^^^

Depends on D57296

Attachment #9116370 - Attachment description: Bug 1604458 - File can be moved only once. → Bug 1604458 - File can be moved only once. r=mhentges

Is the "expected" case correct here?

TEST-copied  This file was moved from TEST.
TEST-moved  This file was copied from TEST.

Don't we want TEST-copied to be "copied", and TEST-moved to be "moved"?

I think it is not easy (or impossible) to recognize which file was copied and which moved.
I've assumed the first rename with a delete of the old file is a move. If there is another one or more - these are the copies.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.