Closed
Bug 1604482
Opened 6 years ago
Closed 5 years ago
Typescript type error about the variable gIsDarkMode
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox73 fixed)
RESOLVED
FIXED
Firefox 73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: julienw, Assigned: brennan.brisad)
Details
Attachments
(1 file)
Run these commands;
$ cd devtools/client/performance-new
$ yarn
$ yarn test
Then the output is:
popup/initializer.js:82:10 - error TS2339: Property 'gIsDarkMode' does not exist on type 'Window & typeof globalThis'.
82 window.gIsDarkMode ? "dark" : "light"
~~~~~~~~~~~
Found 1 error.
error Command failed with exit code 1.
Hey Michael, maybe you can look at this because this is probably coming from one of your "dark mode" patches? We don't run these tests automatically yet, that's why it wasn't caught otherwise.
Flags: needinfo?(brennan.brisad)
|
Reporter | |
Updated•6 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•6 years ago
|
||
Yes, that seems to be something I missed. I'm on it :-)
Flags: needinfo?(brennan.brisad)
|
|
Reporter | |
Updated•6 years ago
|
Assignee: nobody → brennan.brisad
|
|
Assignee | |
Comment 2•6 years ago
|
||
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1fd87ec46d80
Fix TypeScript type error for gIsDarkMode r=gregtatum
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
You need to log in
before you can comment on or make changes to this bug.
Description
•