1604490 - Enable Leanplum for users who have Master Password enabled

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement, P1)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

We would like to enable Leanplum for users who have Master Password enabled. On all channels from Nightly to Release.

This is an additional condition, next to the list of locales.

We should just follow the same value that we use for telemetry around Master Password.

Comment 1

[Andrei Lazar]

Attachment: Bug 1604490 - Enable Leanplum for users who have Master Password enabled r=VladBaicu

Added additional condition in order to enable Leanplum for users that have Master Password enabled.

Depends on D57833

Comment 2

[Andrei Lazar]

Comment on attachment 9117557 [details]
Bug 1604490 - Enable Leanplum for users who have Master Password enabled r=VladBaicu

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required by the marketing team in order to promote migration.
• User impact if declined: Users won't be able to receive notifications from migration campaigns.
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The changes are small and doesn't affect any feature's behavior, but rather helps the marketing team to target specific users.
• String or UUID changes made by this patch:

Comment 3

[Julien Cristau [:jcristau] (back August 18)]

Is there an urgent need for this in 68.4 or can we land it on nightly/beta next week and in release with 68.5 / 73?

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Yes this would allow us to reach a wider set of people that have master passwords set. If they don't get this message they will loose access to the passwords unless they use Sync.

Comment 5

[Julien Cristau [:jcristau] (back August 18)]

OK... How confident are we that this and the patch in 1604249 are correct and will actually work right the first time, with no time to test them in nightly or beta?

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9117557 [details]
Bug 1604490 - Enable Leanplum for users who have Master Password enabled r=VladBaicu

Needed for Fennec->Fenix migration messaging. Approved for 68.5b2.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/1cf25d455122

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Landed on FIREFOX_ESR_68_4_X_RELBRANCH for 68.4.2.
https://hg.mozilla.org/releases/mozilla-esr68/rev/4838599ae75293e2102e7a642ade695505b2fd77