1604491 - Rename DevTools "custom" host to "browsertoolbox" host

Status: RESOLVED FIXED

(DevTools :: Framework, task, P3)

Description

[Julian Descottes [:jdescottes]]

From a discussion in the review of Bug 1603361:
https://phabricator.services.mozilla.com/D56989#inline-348984

We currently support a "custom" host in DevTools. In production code, this is only used when creating a Browser Toolbox. https://searchfox.org/mozilla-central/source/devtools/client/framework/browser-toolbox/window.js#198

We can rename this host to "browsertoolbox", and thanks to that:

• add a isBrowserToolbox getter on toolbox that simply checks the host type
• move some of the complexity handed in browser-toolbox/window.js to the host

https://searchfox.org/mozilla-central/source/devtools/client/framework/browser-toolbox/window.js

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1604491 - Rename CUSTOM DevTools host to BROWSERTOOLBOX

Only renaming methods/variables/files here.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1604491 - Implement host raise/setTitle for browsertoolbox host

Depends on D58235. Move browsertoolbox host logic directly to browsertoolbox host

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1604491 - Remove Toolbox::setBrowserToolbox, use host type to check if BrowserToolbox

Depends on D58236

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1604491 - Additional cleanup in browser-toolbox/window.js

Depends on D58237

Try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=5eabbe90d1384eaafeb37dd9038e52e8973fc60a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5d7f11748dd
Rename CUSTOM DevTools host to BROWSERTOOLBOX r=ochameau
https://hg.mozilla.org/integration/autoland/rev/27f73ed7222f
Implement host raise/setTitle for browsertoolbox host r=ochameau
https://hg.mozilla.org/integration/autoland/rev/c7f8433f168f
Remove Toolbox::setBrowserToolbox, use host type to check if BrowserToolbox r=ochameau
https://hg.mozilla.org/integration/autoland/rev/ad5d17f68cde
Additional cleanup in browser-toolbox/window.js r=ochameau

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b5d7f11748dd
https://hg.mozilla.org/mozilla-central/rev/27f73ed7222f
https://hg.mozilla.org/mozilla-central/rev/c7f8433f168f
https://hg.mozilla.org/mozilla-central/rev/ad5d17f68cde