1611099 - The tooltip is no longer shown when hovering over a stylesheet URL in the Browser Toolbox rule-view

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect)

Description

[Richard Marti (:Paenglab)]

Open Inspector and inspect a node. On the right in the rules tab the different CSS files with the applying rules are shown. Hovering the file name showed the file path. Now nothing is shown. I can't say since when.

Comment 1

[Patrick Brosset <:pbro>]

Thanks for filing Richard. In order to investigate, we'll need a few more information: what operating system are you on? What version of Firefox did this happen on? Also, if you can provide a screenshot or a screen video recording of the bug in action, that'd be super useful.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Working path tooltip when in content mode

Screenshot showing the working tooltip when inspecting the content. When I inspect the browsers chrome with the Browser Toolbox then the tooltips are no more shown.

I tried also inspecting the content with the toolbox detached in its own window. Then the tooltips are still work.

I see this on Linux, Mac and Windows with Nightly.

Comment 3

[Patrick Brosset <:pbro>]

Thanks Richard. So this only happens in the Browser Toolbox. I was able to reproduce. This is a regression. Adjusting the title to make it more self-explanatory.

Comment 4

[Patrick Brosset <:pbro>]

I found the regression:

Last good revision: a2c5a0150d9f5d29524dec420d2e4e9a3ecf8b83
First bad revision: ad5d17f68cde6b8cc3d74a528a2094412dce2b6f
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a2c5a0150d9f5d29524dec420d2e4e9a3ecf8b83&tochange=ad5d17f68cde6b8cc3d74a528a2094412dce2b6f

So, bug 1604491 (which landed in 74) is the culprit here.

[Tracking Requested - why for this release]: This is a regression in 74. 73 is unaffected. It would be good to get a fix in 74, but this isn't a blocker either. The problem is only in devtools and only in the browser toolbox.

Comment 5

[Patrick Brosset <:pbro>]

Julian, do you have any idea how bug 1604491 could have caused this regression? I think what makes links links in the rule-view is the sourceMapURLService in devtools/client/inspector/rules/views/rule-editor.js (the function _updateLocation is what does it). Does that spark any idea?

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1611099 - Do not set frame.tooltip when creating the devtools BrowserToolbox frame

Comment 7

[Julian Descottes [:jdescottes]]

Thanks for the heads up! It's actually impacting all title tooltips.

When we simplified the BrowserToolbox host creation, we tried to reuse the code already existing to create the devtools <frame> (previously the <frame> element for the BrowserToolbox was defined in the markup of the BrowserToolbox document).

The current code is:

function createDevToolsFrame(doc, className) {
  const frame = doc.createXULElement("browser");
  frame.setAttribute("type", "content");
  frame.flex = 1; // Required to be able to shrink when the window shrinks
  frame.className = className;
  frame.tooltip = "aHTMLTooltip";
  return frame;
}

Turns out that setting frame.tooltip = "aHTMLTooltip"; prevents the tooltips from working in the BrowserToolbox. This attribute is normally useful for toolboxes created in XUL documents, because they need to use a dedicated XUL <tooltip> element to handle HTML tooltips. But the Browser Toolbox is loaded in a HTML document and not in a XUL document. There is no <tooltip id="aHTMLTooltip"> available there, and simply adding this attribute probably tricks Firefox into trying to find this aHTMLTooltip to handle tooltips.

Only setting the attribute when loading the toolbox in XUL documents seems to fix the issue.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c37b67472bbf
Do not set frame.tooltip when creating the devtools BrowserToolbox frame r=pbro

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c37b67472bbf

Comment 10

[Pascal Chevrel:pascalc (PTO until Sept 2)]

No need to track as this was broken and fixed during the 74 nightly cycle, thanks for pinging relman!