Closed Bug 1604742 Opened 5 years ago Closed 4 years ago

Bump navigator.userAgent string in Firefox 68.2

Categories

(Firefox :: Settings UI, enhancement)

68 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: Chris78, Unassigned)

References

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Call navigator.userAgent in Firefox 68.2.0esr (64-Bit)

Actual results:

The result is "Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0"

Expected results:

I expected it to be "(...) Firefox/68.2"

If navigator.userAgent includes the minor version in the userAgent-String, shouldn't it reflect the actual minor version of the browser?

Some Background:
There seems to be a change in the events fired when a arrow key is pressed in an input field. In FF 68.1 I recall onkeydown was fired, while in FF 68.2 onkeypress is fired instead. To adopt a webpage's behavior it would be very beneficial if the userAgent string allowed to distinguish between both versions.

Status: UNCONFIRMED → NEW
Component: Untriaged → Preferences
Ever confirmed: true

In FF 68.1 I recall onkeydown was fired, while in FF 68.2 onkeypress is fired instead.

Nakano-san, is this change intentional?

Flags: needinfo?(masayuki)

(In reply to Masatoshi Kimura [:emk] from comment #1)

In FF 68.1 I recall onkeydown was fired, while in FF 68.2 onkeypress is fired instead.

Nakano-san, is this change intentional?

Of course, no.

Chris78:

Does your profile keep default values of all prefs which you see when you type "keypress" into the filter in about:config? Starting from Firefox 66, we stopped dispatching keypress event for non-printable keys like arrow keys. That can be controllable with dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content. I guess in your profile, this is set to false accidentally.

Flags: needinfo?(masayuki) → needinfo?(cgerharz)

I'm sorry, I think I have confused something in the sentence:
"In FF 68.1 I recall onkeydown was fired, while in FF 68.2 onkeypress is fired instead."

Actually the behavior I noticed was just the other way round:
In FF 68.1 an arrow key in a text input fired onkeypress, while in FF 68.2 onkeydown is fired instead.

@masayuki, I will check the settings in about:config as soon as I'm back to my office computer next week and comment again here.

68.2.0esr (64-Bit): arrow keys in an input field fire onkeydown.

In about:config (filtered by keypress) all values are the default values (except extensions.firegestures.keypressgesture which shouldn't be relevant).

I cannot check the behavior in 68.1 anymore, since I don't have it installed anywhere anymore.
Maybe in that version some of my settings in about:config weren't the default ones.

Flags: needinfo?(cgerharz)

Thank you for verifying and feeding it back. Yeah, maybe, the pref was not default, but now set to default, although it shouldn't occur with minor version up. Anyway, current behavior which you see is what I expect. So, closing this bug as WFM. Feel free to reopen this bug if you find non-printable keypress events even with default prefs.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME

Well, my actual bug report was about the navigator.userAgent string.

So, what is your opinion on this:

If navigator.userAgent includes the minor version in the userAgent-String, shouldn't it reflect the actual minor version of the browser?

Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---

I don't think that UA string for ESR shouldn't be changed because changing it may break ESR users' web apps.

RyanVM, what do you think?

Flags: needinfo?(ryanvm)

The current behavior was an explicit decision made in bug 870868. The bug is pretty light on details as to why the change was made, but I would assume it's fingerprinting-related. Anyway, reversing that call would probably require buy-in from Firefox product ownership.

Flags: needinfo?(ryanvm)

Since it's probabaly only me, who stumbled across that tiny imperfection, feel free to wontfix and close this issue.

Thanks anyway.

Closing as wontfix. The only time Firefox has a non-zero minor version number is Firefox ESR and we don't expect functional changes in ESR minor versions that should need version detection, just new bug fixes.

Status: REOPENED → RESOLVED
Closed: 5 years ago4 years ago
Resolution: --- → WONTFIX
See Also: → 870868
You need to log in before you can comment on or make changes to this bug.