870868 - Freeze the second number of the UA Gecko version at zero

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Alex Keybl [:akeybl]]

Please freeze the second number of the UA Gecko version at zero. So for instance Firefox 24.1 would show up as Firefox 24.0 in the UA.

Comment 1

[Alex Keybl [:akeybl]]

Dao - is this something you wouldn't mind resolving?

Comment 2

[Dão Gottwald [:dao]]

Yep.

Comment 3

[Justin Wood (:Callek)]

To be clear, from e-mail thread I suspect alex wants a UA that also shows app UA of Firefox/N.0

However there are other products (e.g. SeaMonkey) that need that second digit to be significant (SeaMonkey/2.19 as an example)

I don't *think* that this will break us as filed, but wanted to call out my concern as-community before the patch is even attached.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

Comment 5

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb0fbf5c76f8

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fb0fbf5c76f8

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 748254 [details] [diff] [review]
patch

[Approval Request Comment]
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 8

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/31ec92d3979d