Closed
Bug 1605200
Opened 4 years ago
Closed 4 years ago
Cleanup JSFunction FunctionFlags
Categories
(Core :: JavaScript Engine, task, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(3 files)
The JSFunction FunctionFlags should be cleaned up for readability.
|
Assignee | |
Comment 1•4 years ago
|
||
Fix the formatting, commenting, ordering of the flags. Also move the function
kind bits to the beginning of the flag word.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Cleanup the aliases we use for constructing different types of functions.
Always specify the function kind explicitly for readability.
Depends on D57851
|
|
Assignee | |
Comment 3•4 years ago
|
||
Also add this helper to FunctionBox for consistency.
Depends on D57852
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/be05ad009c21 Cleanup JSFunction FunctionFlags. r=jandem https://hg.mozilla.org/integration/autoland/rev/a14f6d02534c Cleanup the derived JSFunction flags. r=jandem https://hg.mozilla.org/integration/autoland/rev/ad5fcfb30860 Use JSFunction::isClassConstructor shorthand. r=jandem
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/be05ad009c21
https://hg.mozilla.org/mozilla-central/rev/a14f6d02534c
https://hg.mozilla.org/mozilla-central/rev/ad5fcfb30860
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in
before you can comment on or make changes to this bug.
Description
•