Cleanup XDRInterpretedFunction
Categories
(Core :: JavaScript Engine, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(5 files)
The current implementation is pretty inconsistent with other parts of engine and is the JSFunction::kind() temporarily has the wrong value. This is blocking Bug 1600705.
|
Assignee | |
Comment 1•4 years ago
|
||
Pass appropriate arguments to NewFunctionWithProto instead of filling them
after the fact. The script should be transcoded after the function is set up.
Also stop preserving the NEW_SCRIPT_CLEARED flag in XDR.
|
|
Assignee | |
Comment 2•4 years ago
|
||
We had a few extra RootedFunction when we only cared if about if the pointer
was null or not, so lets remove them. Also rename to isFunctionScript since
this is called for stand-alone functions as well. Semantics should be
unchanged.
Depends on D57862
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D57917
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D57918
|
|
Assignee | |
Comment 5•4 years ago
|
||
Move the transcoding from XDRLazyScript and XDRRelazificationInfo into
LazyScript::XDRScriptData to avoid duplication. Add similar code for non-lazy
scripts for consistency.
Depends on D57919
|
|
Assignee | |
Comment 6•4 years ago
|
||
I expanded the scope of cleanup because this code was getting in the way of eliminating LazyScripts.
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6204c67cacf5 Cleanup XDRInterpretedFunction. r=jandem https://hg.mozilla.org/integration/autoland/rev/0f37ad6a815e Remove unnecessary roots in XDRScript. r=caroline https://hg.mozilla.org/integration/autoland/rev/94c7c031cfa1 Cleanups in js::XDRScript. r=jandem https://hg.mozilla.org/integration/autoland/rev/4eaa8b8ff4f6 Cleanups in XDRScriptGCThing. r=jandem https://hg.mozilla.org/integration/autoland/rev/5b103899895f Fixup XDR of FieldInitializers. r=jandem
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6204c67cacf5
https://hg.mozilla.org/mozilla-central/rev/0f37ad6a815e
https://hg.mozilla.org/mozilla-central/rev/94c7c031cfa1
https://hg.mozilla.org/mozilla-central/rev/4eaa8b8ff4f6
https://hg.mozilla.org/mozilla-central/rev/5b103899895f
|
||
Comment 9•4 years ago
|
||
== Change summary for alert #24578 (as of Mon, 23 Dec 2019 07:43:05 GMT) ==
Improvements:
1% Base Content JS windows7-32-shippable opt 2,969,269.33 -> 2,935,912.00
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24578
Description
•