Closed Bug 1605246 Opened 4 years ago Closed 4 years ago

Main process is not killed when content process dies during tests

Categories

(GeckoView :: Sandboxing, defect)

Unspecified
All
defect
Not set
normal

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: agi, Assigned: agi)

References

Details

Attachments

(1 file)

The main process should shut down when a content process crashes during a test.

We try to do that here: https://searchfox.org/mozilla-central/rev/b243debf6235b050b42fd2eb615fdc729636ca6b/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/rule/GeckoSessionTestRule.java#1034-1040

but somehow that code is not working, see e.g. this test run: https://firefoxci.taskcluster-artifacts.net/FbcqsOY7Q5SEO9gDkX8kEQ/0/public/test_info//logcat-emulator-5554.log

where the content process crashes with this assertion:

F MOZ_Assert: Assertion failure: ObserverCount() == mEarlyRunners.Length() (observers, except pending selection scrolls, should have been unregistered), at /builds/worker/workspace/build/src/layout/base/nsRefreshDriver.cpp:1187

but no main process crash is registered: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=281962476&repo=autoland&lineNumber=2215

Right now we only detect onCrash on mochitests/reftests and onKill on junit
tests.

This change makes it so we wait for both on every type of test.

Assignee: nobody → agi
Status: NEW → ASSIGNED
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea0f20482d4c
Kill main process if child process dies during tests. r=snorp
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73

Moving content process management bugs to the new GeckoView::Sandboxing component.

Component: General → Sandboxing
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: