1611468 - JUnit test failures due to content process crash are misreported

Status: NEW

(GeckoView :: General, defect, P2)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Sometimes a junit test can fail because the content process crashes. In this case we should report the crash as the reason for the failure, instead of e.g. a timeout.

Example failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286355465&repo=try&lineNumber=2251

And we can see in the logcat linked from there:

01-24 14:43:21.988 3120 3135 F MOZ_Assert: Assertion failure: ObserverCount() == mEarlyRunners.Length() (observers, except pending selection scrolls, should have been unregistered), at /builds/worker/workspace/build/src/layout/base/nsRefreshDriver.cpp:1188

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Looks like this is the same as Bug 1605246. It's even the same assertion. I won't reopen that since we already have a patch there.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Current theory is that we are not receiving onCrash() because we're in-between tests or are otherwise not monitoring an open session when the content crash occurs. We should instead just use the crash handling service to detect these and check for content crashes in between each test.

Comment 3

[Chris Peterson [:cpeterson]]

Moving content process management bugs to the new GeckoView::Sandboxing component.