1605282 - Perma tier 2 GECKO(1114) | Assertion failure: prevState == JS::HeapState::Idle, at /builds/worker/workspace/build/src/js/src/gc/GC.cpp:6234

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: aciure [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=281988940&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/NIdcIKLnQpeooX6n8gcnsQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2019-12-19T22:24:56.521Z] 22:24:56 INFO - TEST-START | devtools/client/webconsole/test/browser/browser_console_chrome_context_message.js
[task 2019-12-19T22:24:56.583Z] 22:24:56 INFO - GECKO(1114) | [Child 1312: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (0x7fa5ff32af20) [pid = 1312] [serial = 1] [outer = (nil)]
[task 2019-12-19T22:24:56.583Z] 22:24:56 INFO - GECKO(1114) | [Child 1312, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/workspace/build/src/layout/base/nsPresContext.cpp, line 848
[task 2019-12-19T22:24:56.586Z] 22:24:56 INFO - GECKO(1114) | [Child 1312: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (0x7fa5ff457800) [pid = 1312] [serial = 2] [outer = 0x7fa5ff32af20]
[task 2019-12-19T22:24:56.614Z] 22:24:56 INFO - GECKO(1114) | [Child 1283: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7fe1ac2d0000 == 0 [pid = 1283] [id = {fdcaa7a4-df77-421d-9259-f71d08a7d8ea}] [url = http://example.com/browser/devtools/client/webconsole/test/browser/test-console.html?1576794289665]
[task 2019-12-19T22:24:56.864Z] 22:24:56 INFO - GECKO(1114) | [Child 1283: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (0x7fe1ad1daf20) [pid = 1283] [serial = 1] [outer = (nil)] [url = http://example.com/browser/devtools/client/webconsole/test/browser/test-console.html?1576794289665]
[task 2019-12-19T22:24:56.864Z] 22:24:56 INFO - GECKO(1114) | [Child 1283: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (0x7fe1acfcfc00) [pid = 1283] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2019-12-19T22:24:56.864Z] 22:24:56 INFO - GECKO(1114) | [Child 1283: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (0x7fe1acfd9400) [pid = 1283] [serial = 3] [outer = (nil)] [url = http://example.com/browser/devtools/client/webconsole/test/browser/test-console.html?1576794289665]
[task 2019-12-19T22:24:57.040Z] 22:24:57 INFO - GECKO(1114) | [Parent 1114: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f1296885800 == 7 [pid = 1114] [id = {762afa89-f2cc-4443-8603-a2900a76ade2}]
[task 2019-12-19T22:24:57.041Z] 22:24:57 INFO - GECKO(1114) | [Parent 1114: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 15 (0x7f129f4973e0) [pid = 1114] [serial = 15] [outer = (nil)]
[task 2019-12-19T22:24:57.041Z] 22:24:57 INFO - GECKO(1114) | [Parent 1114: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 16 (0x7f12971b4000) [pid = 1114] [serial = 16] [outer = 0x7f129f4973e0]
[task 2019-12-19T22:24:57.056Z] 22:24:57 INFO - GECKO(1114) | [Parent 1114, Main Thread] WARNING: Attempting to get a displayport from a content with no primary frame!: file /builds/worker/workspace/build/src/layout/base/nsLayoutUtils.cpp, line 790
[task 2019-12-19T22:24:57.204Z] 22:24:57 INFO - GECKO(1114) | [Child 1283, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/workspace/build/src/xpcom/base/nsCycleCollector.cpp, line 3361
[task 2019-12-19T22:24:57.321Z] 22:24:57 INFO - GECKO(1114) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpzuTwIH.mozrunner/runtests_leaks_tab_pid1333.log
[task 2019-12-19T22:24:57.349Z] 22:24:57 INFO - GECKO(1114) | [Child 1333, Main Thread] WARNING: No CID found when attempting to map contract ID: file /builds/worker/workspace/build/src/xpcom/components/nsComponentManager.cpp, line 721
[task 2019-12-19T22:24:57.629Z] 22:24:57 INFO - GECKO(1114) | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-12-19T22:24:57.636Z] 22:24:57 INFO - GECKO(1114) | [Child 1333, Main Thread] WARNING: Could not get the program name for a cubeb stream.: 'NS_SUCCEEDED(rv)', file /builds/worker/workspace/build/src/dom/media/CubebUtils.cpp, line 381
[task 2019-12-19T22:24:57.712Z] 22:24:57 INFO - GECKO(1114) | Assertion failure: prevState == JS::HeapState::Idle, at /builds/worker/workspace/build/src/js/src/gc/GC.cpp:6234
[task 2019-12-19T22:24:57.869Z] 22:24:57 INFO - GECKO(1114) | [Child 1333, Main Thread] WARNING: could not set real-time limit at process startup: file /builds/worker/workspace/build/src/dom/ipc/ContentChild.cpp, line 1819
[task 2019-12-19T22:24:58.218Z] 22:24:58 INFO - GECKO(1114) | [Child 1172: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 14 (0x7fb843ec8c00) [pid = 1172] [serial = 4] [outer = (nil)] [url = about:blank]
[task 2019-12-19T22:24:58.219Z] 22:24:58 INFO - GECKO(1114) | [Child 1172: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 13 (0x7fb843ecf400) [pid = 1172] [serial = 10] [outer = (nil)] [url = about:blank]
[task 2019-12-19T22:24:58.219Z] 22:24:58 INFO - GECKO(1114) | [Child 1172: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 12 (0x7fb843ecd000) [pid = 1172] [serial = 8] [outer = (nil)] [url = about:blank]
[task 2019-12-19T22:24:58.219Z] 22:24:58 INFO - GECKO(1114) | [Child 1172: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 11 (0x7fb843e92800) [pid = 1172] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2019-12-19T22:24:58.219Z] 22:24:58 INFO - GECKO(1114) | [Child 1172: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (0x7fb843ecac00) [pid = 1172] [serial = 6] [outer = (nil)] [url = about:blank]
[task 2019-12-19T22:24:58.556Z] 22:24:58 INFO - GECKO(1114) | [Child 1172: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (0x7fb8441ef7a0) [pid = 1172] [serial = 9] [outer = (nil)] [url = moz-extension://731c2134-5cb3-4f16-8262-28336b8f32be/_generated_background_page.html]
[task 2019-12-19T22:24:58.653Z] 22:24:58 INFO - GECKO(1114) | [Child 1193: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (0x7f6ee37b1800) [pid = 1193] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2019-12-19T22:24:58.654Z] 22:24:58 INFO - GECKO(1114) | [Child 1193: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (0x7f6ee3b98800) [pid = 1193] [serial = 5] [outer = (nil)] [url = about:blank]
[task 2019-12-19T22:24:59.079Z] 22:24:59 INFO - GECKO(1114) | [Child 1193: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (0x7f6ee3748f20) [pid = 1193] [serial = 1] [outer = (nil)] [url = about:blank]
[task 2019-12-19T22:24:59.469Z] 22:24:59 INFO - GECKO(1114) | [Child 1255: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7fcf188ce000 == 0 [pid = 1255] [id = {6c9df896-6dd2-4618-8043-cbfcb0b1d504}] [url = about:blank]
[task 2019-12-19T22:24:59.935Z] 22:24:59 INFO - GECKO(1114) | [Parent 1114: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 15 (0x7f12a1c46c00) [pid = 1114] [serial = 5] [outer = (nil)] [url = about:blank]
[task 2019-12-19T22:24:59.935Z] 22:24:59 INFO - GECKO(1114) | [Parent 1114: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 14 (0x7f129f44b400) [pid = 1114] [serial = 9] [outer = (nil)] [url = about:blank]
[task 2019-12-19T22:25:00.576Z] 22:25:00 INFO - GECKO(1114) | [Child 1333: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7fc34b6ce000 == 1 [pid = 1333] [id = {6ec2d725-dc7c-435d-99c3-d48b7431a656}]
[task 2019-12-19T22:25:00.638Z] 22:25:00 INFO - GECKO(1114) | [Child 1333: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (0x7fc34b52cf20) [pid = 1333] [serial = 1] [outer = (nil)]
[task 2019-12-19T22:25:00.646Z] 22:25:00 INFO - GECKO(1114) | [Child 1333, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/workspace/build/src/layout/base/nsPresContext.cpp, line 848
[task 2019-12-19T22:25:00.646Z] 22:25:00 INFO - GECKO(1114) | [Child 1333: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (0x7fc34c48fc00) [pid = 1333] [serial = 2] [outer = 0x7fc34b52cf20]
[task 2019-12-19T22:25:00.763Z] 22:25:00 INFO - GECKO(1114) | [Child 1333, Main Thread] WARNING: Trying to request nsIHttpChannel from DocumentChannelChild, this is likely broken: file /builds/worker/workspace/build/src/netwerk/ipc/DocumentChannelChild.cpp, line 63
[task 2019-12-19T22:25:00.763Z] 22:25:00 INFO - GECKO(1114) | [Child 1333, Main Thread] WARNING: Trying to request nsIHttpChannel from DocumentChannelChild, this is likely broken: file /builds/worker/workspace/build/src/netwerk/ipc/DocumentChannelChild.cpp, line 63
[task 2019-12-19T22:25:00.778Z] 22:25:00 INFO - GECKO(1114) | [Child 1333: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (0x7fc34c498c00) [pid = 1333] [serial = 3] [outer = 0x7fc34b52cf20]
[task 2019-12-19T22:25:01.020Z] 22:25:01 INFO - GECKO(1114) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpzuTwIH.mozrunner/runtests_leaks_tab_pid1359.log

Comment 1

[Jon Coppeard (:jonco)]

Annoyingly there's no stack trace for this assertion.

The log contains a later assertion failure which looks like bug 1604593:

Assertion failure: IsWindowProxy(obj), at /builds/worker/workspace/build/src/js/src/vm/Compartment.cpp:247

Comment 2

[Jon Coppeard (:jonco)]

(In reply to Jon Coppeard (:jonco) from comment #1)
Oh, there is but it was after the one for the other assertion failure:

Crash dump filename: /tmp/tmpzuTwIH.mozrunner/minidumps/35b8d517-de35-f1a6-5637-6a1cd00d6c5c.dmp
Operating system: Linux
                  0.0.0 Linux 4.4.0-1014-aws #14taskcluster1-Ubuntu SMP Tue Apr 3 10:27:00 UTC 2018 x86_64
CPU: amd64
     family 6 model 85 stepping 4
     2 CPUs

GPU: UNKNOWN

Crash reason:  SIGSEGV /SEGV_MAPERR
Crash address: 0x0
Process uptime: not available

Thread 0 (crashed)
 0  libxul.so!js::gc::AutoHeapSession::AutoHeapSession(js::gc::GCRuntime*, JS::HeapState) [GC.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 6234 + 0x29]
 1  libxul.so!JS_IterateCompartments(JSContext*, void*, JS::CompartmentIterResult (*)(JSContext*, void*, JS::Compartment*)) [PublicIterators.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 208 + 0x54]
 2  libxul.so!XPCJSRuntime::AssertInvalidWrappedJSNotInTable(nsXPCWrappedJS*) const [XPCWrappedJS.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 473 + 0x12]
 3  libxul.so!XPCJSRuntime::RemoveWrappedJS(nsXPCWrappedJS*) [XPCWrappedJS.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 432 + 0x5]
 4  libxul.so!nsXPCWrappedJS::Destroy() [XPCWrappedJS.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 483 + 0x10]
 5  libxul.so!nsXPCWrappedJS::~nsXPCWrappedJS() [XPCWrappedJS.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 429 + 0x4a]
 6  libxul.so!nsXPCWrappedJS::~nsXPCWrappedJS() [XPCWrappedJS.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 429 + 0xe]
 7  libxul.so!nsXPCWrappedJS::Release() [XPCWrappedJS.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 270 + 0x9]
 8  libxul.so!nsTArray_Impl<RefPtr<nsXPCWrappedJS>, nsTArrayInfallibleAllocator>::ClearAndRetainStorage() [nsTArray.h:8e1b11b00157269f1f781753efc241e005efeaf1 : 1333 + 0x20]
 9  libxul.so!nsTArray_Impl<RefPtr<nsXPCWrappedJS>, nsTArrayInfallibleAllocator>::~nsTArray_Impl() [nsTArray.h:8e1b11b00157269f1f781753efc241e005efeaf1 : 914 + 0x8]
10  libxul.so!JSObject2WrappedJSMap::UpdateWeakPointersAfterGC() [XPCMaps.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 70 + 0x5]
11  libxul.so!XPCJSRuntime::WeakPointerZonesCallback(JSContext*, void*) [XPCJSRuntime.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 940 + 0xc]
12  libxul.so!js::gc::GCRuntime::callWeakPointerZonesCallbacks() const [GC.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 1582 + 0x9]
13  libxul.so!js::gc::GCRuntime::beginSweepingSweepGroup(JSFreeOp*, js::SliceBudget&) [GC.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 5142 + 0x8]
14  libxul.so!sweepaction::SweepActionSequence::run(js::gc::SweepAction::Args&) [GC.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 5849 + 0x9]
15  libxul.so!sweepaction::SweepActionForEach<js::gc::SweepGroupsIter, JSRuntime*>::run(js::gc::SweepAction::Args&) [GC.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 5884 + 0x17]
16  libxul.so!js::gc::GCRuntime::performSweepActions(js::SliceBudget&) [GC.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 6017 + 0x3]
17  libxul.so!js::gc::GCRuntime::incrementalSlice(js::SliceBudget&, mozilla::Maybe<JSGCInvocationKind> const&, JS::GCReason, js::gc::AutoGCSession&) [GC.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 6539 + 0xb]
18  libxul.so!js::gc::GCRuntime::gcCycle(bool, js::SliceBudget, mozilla::Maybe<JSGCInvocationKind> const&, JS::GCReason) [GC.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 6952 + 0x16]
19  libxul.so!js::gc::GCRuntime::collect(bool, js::SliceBudget, mozilla::Maybe<JSGCInvocationKind> const&, JS::GCReason) [GC.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 7137 + 0x25]
20  libxul.so!js::gc::GCRuntime::gc(JSGCInvocationKind, JS::GCReason) [GC.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 7219 + 0x62]
21  libxul.so!JSRuntime::destroyRuntime() [Runtime.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 286 + 0xf]
22  libxul.so!js::DestroyContext(JSContext*) [JSContext.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 199 + 0x8]
23  libxul.so!mozilla::CycleCollectedJSContext::~CycleCollectedJSContext() [CycleCollectedJSContext.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 104 + 0xc]
24  libxul.so!XPCJSContext::~XPCJSContext() [XPCJSContext.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 1032 + 0x14]
25  libxul.so!XPCJSContext::~XPCJSContext() [XPCJSContext.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 996 + 0xe]
26  libxul.so!nsXPConnect::~nsXPConnect() [nsXPConnect.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 123 + 0xf]
27  libxul.so!nsXPConnect::~nsXPConnect() [nsXPConnect.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 94 + 0xe]
28  libxul.so!nsXPConnect::Release() [nsXPConnect.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 47 + 0x44]
29  libxul.so!nsXPConnect::ReleaseXPConnectSingleton() [nsXPConnect.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 157 + 0x5]
30  libxul.so!nsComponentManagerImpl::Shutdown() [nsComponentManager.cpp:8e1b11b00157269f1f781753efc241e005efeaf1 : 933 + 0x5]

Comment 3

[Intermittent Failures Robot]

11 failures in 4582 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 11

Platform breakdown:

• linux64: 11

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1605282&startday=2019-12-16&endday=2019-12-22&tree=all

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

This seems to perma fail on central. I started backfills: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux64%2Fdebug-mochitest-devtools-chrome-fis-e10s-12%2Cm-fis%28dt12%29&tochange=8e1b11b00157269f1f781753efc241e005efeaf1&fromchange=d01f200c7b3ac2a864362d6c01bbbe4e50962301&selectedJob=282547373

Comment 5

[Cosmin Sabou [:CosminS]]

This assertion started with the landing of Bug 1588050 https://hg.mozilla.org/integration/autoland/rev/721fefd09f1631de57bdf9a5b1737f4ab2ddf0ab
till then there was https://treeherder.mozilla.org/logviewer.html#?job_id=282611810&repo=autoland

Assertion failure: IsWindowProxy(obj), at /builds/worker/workspace/build/src/js/src/vm/Compartment.cpp:247

https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux64%2Fdebug-mochitest-devtools-chrome-fis-e10s-12%2Cm-fis%28dt12%29&tochange=5c1f0479e011c12dfdbfb4f7c9ec15e6653f0b07&fromchange=5e8b48c8cd93ae318b2963de1b3c1db0710c0242&selectedJob=282611808
Julian, any ideas why this would happen?

Comment 6

[Intermittent Failures Robot]

27 failures in 1365 pushes (0.02 failures/push) were associated with this bug in the last 7 days.

This is the #34 most frequent failure this week.

Repository breakdown:

• mozilla-central: 27

Platform breakdown:

• linux64: 27

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1605282&startday=2019-12-23&endday=2019-12-29&tree=all

Comment 7

[Jon Coppeard (:jonco)]

Attachment: Bug 1605282 - Don't call JS_IterateCompartments while inside GC finalization r?mccr8

This function doesn't expected to be called while running inside of the GC and asserts. At the moment this happens inside XPCJSRuntime::AssertInvalidWrappedJSNotInTable which is called while destroying a nsXPCWrappedJS. We should probably just skip the assertions in this case.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c949f9c9c832
Don't call JS_IterateCompartments while inside GC finalization r=mccr8

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c949f9c9c832

Comment 10

[Noemi Erli[:noemi_erli]]

This is still happening: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283276512&repo=autoland&lineNumber=8192

Comment 11

[Intermittent Failures Robot]

15 failures in 403 pushes (0.037 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 15

Platform breakdown:

• windows7-32: 15

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1605282&startday=2020-01-02&endday=2020-01-02&tree=all

Comment 12

[Julian Descottes [:jdescottes]]

GC is not really my area so I am not sure why this triggered an intermittent, but the change that landed in Bug 1588050 did have an impact on many tests running in the chunk that fails here, so it seems connected indeed. What Bug 1588050 changed is that it enable our "multiprocess" browser console and browser toolbox by default. So for this Browser Console test, this means that we are starting additional DebuggerServers in content processes.

The failure used to happen twice in the early logs:

• once in browser_console_chrome_context_message.js
• once in browser_console_error_source_click.js

It seems that the first occurrence is gone now (and was gone even before the patch which landed yesterday). I wonder if https://bugzilla.mozilla.org/show_bug.cgi?id=1605152 had any impact there. It disabled the multiprocess browser toolbox in the test running before browser_console_chrome_context_message.
In recent logs, if we scroll up before the GC error, we can see an error in browser_console_devtools_loader_exception.js which runs right before browser_console_error_source_click.js:

error: resource://devtools/shared/protocol/Front.js, line 68: Error: Connection closed, pending request to server15.conn0.content-process46/console2, type getCachedMessages failed
Request stack:
send/<@resource://devtools/shared/transport/local-transport.js:70:25
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22
DevToolsUtils.executeSoon*exports.executeSoon@resource://devtools/shared/DevToolsUtils.js:62:21
send@resource://devtools/shared/transport/local-transport.js:58:21
send@resource://devtools/server/debugger-server-connection.js:91:20
onProcessListChanged@resource://devtools/server/actors/root.js:562:15
observe@resource://devtools/server/actors/process.js:73:12
_insertBrowser@chrome://browser/content/tabbrowser.js:2347:24
addTab@chrome://browser/content/tabbrowser.js:2846:16
loadOneTab@chrome://browser/content/tabbrowser.js:1642:22
BrowserViewSourceOfDocument@chrome://browser/content/browser.js:3258:24
viewSource@chrome://global/content/viewSourceUtils.js:63:18
viewSource@resource://devtools/client/webconsole/webconsole.js:208:27
onViewSource@resource://devtools/client/webconsole/service-container.js:40:32
onClick@resource://devtools/client/shared/components/Frame.js:275:20
invokeGuardedCallbackImpl@resource://devtools/client/shared/vendor/react-dom.js:74:10
[...]
dispatchInteractiveEvent@resource://devtools/client/shared/vendor/react-dom.js:4328:21
@chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_console_devtools_loader_exception.js:57:16
Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
Tester_execTest@chrome://mochikit/content/browser-test.js:1097:11
nextTest/<@chrome://mochikit/content/browser-test.js:925:14
SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67

Let's try disabling the multiprocess browser toolbox in this test to see if it fixes the intermittent, and then we can move from there.
Try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b588f1f3f6b27a69ba9b17e12adf3637ee91b3f

Comment 13

[Julian Descottes [:jdescottes]]

Attachment: Bug 1605282 - Disable multiprocess browser toolbox in browser_console_devtools_loader_exception.js

Comment 14

[Intermittent Failures Robot]

27 failures in 1862 pushes (0.015 failures/push) were associated with this bug in the last 7 days.

This is the #29 most frequent failure this week.

Repository breakdown:

• mozilla-central: 12
• autoland: 15

Platform breakdown:

• linux64: 12
• windows7-32: 15

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1605282&startday=2019-12-30&endday=2020-01-05&tree=all

Comment 15

[Jon Coppeard (:jonco)]

Attachment: Bug 1605282 - Ensure mGCIsRunning flag is set inside WeakPointerZonesCallback, which is always called from inside the GC r?mccr8

The previous patch was incorrect since by my logic mGCIsRunning should already have been true in AssertInvalidWrappedJSNotInTable. This ends up being false in two situations 1) during shutdown when the finalization callback that sets it has been removed and 2) when called during compacting GC.

This patch fixes the situation by setting it explicitly while we're inside WeakPointerZonesCallback and restoring the original value when we leave.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d79d00528a4
Ensure mGCIsRunning flag is set inside WeakPointerZonesCallback, which is always called from inside the GC r=mccr8

Comment 17

[Jon Coppeard (:jonco)]

Attachment: Bug 1605282 - Fix typo in comment r?mccr8 DONTBUILD

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3829f3fd6f91
Fix typo in comment r=mccr8 DONTBUILD

Comment 19

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0d79d00528a4
https://hg.mozilla.org/mozilla-central/rev/3829f3fd6f91

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Given that we don't run Fission tests on Beta, I'm not sure we need to worry about uplifting this. Are there real-world reasons for considering doing so, Jon?

Comment 21

[Jon Coppeard (:jonco)]

This affects debug builds only so we don't need to uplift.

Comment 22

[Intermittent Failures Robot]

4 failures in 4472 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 4

Platform breakdown:

• linux64: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1605282&startday=2020-01-06&endday=2020-01-12&tree=all