1605380 - Avoid calculating snapped bounds for some display items twice

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Miko Mynttinen]

The snapped bounds for Rectangle, ClearRectangle, HitTest, and BackdropFilter display items are the same as clip rect, so we can avoid some work here.

Comment 1

[Miko Mynttinen]

Attachment: Bug 1605380 - Avoid calculating snapped bounds for some display items twice r=aosmond

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9cbe7b9ad94
Avoid calculating snapped bounds for some display items twice r=aosmond

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for WR failures on background-border-collapsed-gradient.html .

Backout link: https://hg.mozilla.org/integration/autoland/rev/e94a014eb27e172be7f6b3860806803159d3d1f2
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282134345&repo=autoland&lineNumber=19619

Comment 4

[Miko Mynttinen]

This is very unexpected: the resulting bounds or clip rects should not have changed with this patch. I am looking into this.

Comment 5

[Miko Mynttinen]

(In reply to Miko Mynttinen [:miko] (PTO until Jan 14th) from comment #4)

This is very unexpected: the resulting bounds or clip rects should not have changed with this patch. I am looking into this.

What changed was that some callers of process_common_properties_with_bounds() were expecting it to return unsnapped rect. I restored this behavior and refactored the code to make this more explicit.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71e04bcbb142
Avoid calculating snapped bounds for some display items twice r=aosmond

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/71e04bcbb142