Closed Bug 1605380 Opened 2 months ago Closed 2 months ago

Avoid calculating snapped bounds for some display items twice

Categories

(Core :: Graphics: WebRender, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: miko, Assigned: miko)

References

Details

(Keywords: perf)

Attachments

(1 file)

The snapped bounds for Rectangle, ClearRectangle, HitTest, and BackdropFilter display items are the same as clip rect, so we can avoid some work here.

Pushed by mikokm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c9cbe7b9ad94
Avoid calculating snapped bounds for some display items twice r=aosmond

This is very unexpected: the resulting bounds or clip rects should not have changed with this patch. I am looking into this.

Flags: needinfo?(mikokm)

(In reply to Miko Mynttinen [:miko] (PTO until Jan 14th) from comment #4)

This is very unexpected: the resulting bounds or clip rects should not have changed with this patch. I am looking into this.

What changed was that some callers of process_common_properties_with_bounds() were expecting it to return unsnapped rect. I restored this behavior and refactored the code to make this more explicit.

Pushed by mikokm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/71e04bcbb142
Avoid calculating snapped bounds for some display items twice r=aosmond
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.