1605387 - Move js::ImmutableScriptData to a new header file

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Ted Campbell [:tcampbell]]

This structure will be shared between the stencil structures and the vm structures. We should move JSTryNote / ScopeNote / ImmutableScriptData to a separate header.

• Figure out name for header (frontend/StencilScriptData.h maybe?)
• Remove XDR accessors from JSTryNote / ScopeNote / ImmutableScriptData)
• Move these to a js::stencil namespace and rename JSTryNote
• In JSScript.h, we can pull these names into js namespace with an alias
• Fix formatting of comments for the data structure.

Comment 1

[Caroline Cullen [:caroline]]

Attachment: Bug 1605387 - Move JSTryNote, ScopeNote, and ImmutableScriptData into SharedStencil.h. r=mgaudet

Comment 2

[Caroline Cullen [:caroline]]

Attachment: Bug 1605387 - Remove XDR accessors on JSTryNote and ScopeNote. r=mgaudet

Depends on D67188

Comment 3

[Caroline Cullen [:caroline]]

Attachment: Bug 1605387 - Rename JSTryNote to TryNote, move into js namespace, and add default initialization. r=mgaudet

Depends on D67189

Comment 4

[Caroline Cullen [:caroline]]

Pulling move JSTryNote / ScopeNote / ImmutableScriptData into js::stencil namespace and aliasing them in JSScript.h into a separate bug.

Comment 5

[Jan de Mooij [:jandem]]

Note that arai is also making some of these changes in bug 1622530. It would be good to coordinate :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83d3d0df06b7
Move JSTryNote, ScopeNote, and ImmutableScriptData into SharedStencil.h. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/adb269256322
Remove XDR accessors on JSTryNote and ScopeNote. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/10b146b10dc1
Rename JSTryNote to TryNote, move into js namespace, and add default initialization. r=mgaudet

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/83d3d0df06b7
https://hg.mozilla.org/mozilla-central/rev/adb269256322
https://hg.mozilla.org/mozilla-central/rev/10b146b10dc1