1605795 - [Wayland] Extension popup window disappears when tooltip is displayed

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Viktor Jägersküpper]

Steps to reproduce:

1. Install an extension which can display a popup window (e.g. NoScript, uBlock Origin).
2. Click on the extension icon to display the popup window.
3. Move the mouse pointer to another element in the toolbar and wait until the tooltip appears (this doesn't always work for me).
4. The extension popup window disappears.

This is a regression introduced by bug 1585918.

Comment 1

[Viktor Jägersküpper]

I forgot to mention that I see the following in the console:

Gdk-WARNING: Tried to map a popup with a non-top most parent

Comment 2

[Kestrel]

Can confirm regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fd4631c7d8cb0a07c3713894879d22be070a6b6b&tochange=6e1f760e5b8dc7e363962fb1ec2f8084c5a95f7d

Comment 3

[Jan Horak [:jhorak]]

Attachment: Bug 1605795 - Attach new popup to last opened popup or toplevel window; r=stransky

The most common case is that the popup is attached to last opened window. First
we need to hide tooltips so we don't attach the new window to them, then the
menu tree has to be clean up to also avoid wrong popup parent.

If there is no window opened we will attach the window to the toplevel window.

There's also one exception regarding widget-overflow panel: popups with remote content
and widget-overflow panel have to replace all other windows otherwise they will be
attached to wrong parent.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12c004663a5c
Attach new popup to last opened popup or toplevel window; r=stransky

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/12c004663a5c

Comment 6

[luis.pabon]

Is there any chance this can be ported to FF 73? The bug breaks a lot of other plugins like Bitwarden.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Fx73 is due to ship on Tuesday and the final RC build has already been created. That said, we can leave this set to fix-optional as a possible ride-along fix in case of a 73.0.1 dot release.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Fedora can ship it as a downstream patch and I'm not aware of any other distro which runs Wayland by default now.

Comment 9

[luis.pabon]

I didn't realise final 73 was so close. Please don't complicate your work on my behalf - I can simply switch to the beta channel for a proper fix.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Sounds like we can let this fix ride Fx74 to release then. Thanks.