1621660 - [Wayland] Clear Recent History dropdown list items cannot be selected with the mouse

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[Kestrel]

STR:

1. Press Ctrl+Shift+Del to show the "Clear Recent History" dialog.
2. Click the time range dropdown.
3. Try to click on a different menu item with the mouse eg "Everything".

The dropdown menu items do not response to mouse hover or clicks. Keyboard arrow keys work.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=601b94cc2e12bb1749342266f4ee3f25121a04bf&tochange=12c004663a5c03385170eb1ac009e3bcdc2547ea

Regressed by Bug 1605795.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Jan, can you look at it please?
Thanks.

Comment 2

[Jens Stutte [:jstutte]]

Hi Martin, can you please (let) set a priority here? Thank you!

Comment 3

[Christian Stadelmann]

(In reply to Kestrel from comment #0)

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=601b94cc2e12bb1749342266f4ee3f25121a04bf&tochange=12c004663a5c03385170eb1ac009e3bcdc2547ea

Regressed by Bug 1605795.

I think this bug is older. Downstream bug report from 2019-05-15: https://bugzilla.redhat.com/show_bug.cgi?id=1752240

Comment 4

[Jan Horak [:jhorak]]

This is because the Clear recent history dialog is modal. It's always 'above' the Time range to clear dropdown (dropdown does not receive the OnEnterNotify). Setting dropdown menu be also modal somehow workaround the problem but another occurs: You cannot close the dropdown by clicking back to Clear history window.

It seems to be related on how we're creating the popup menus. I need to investigate further the GTK3 code to find some solution - or reproduce it upstream.

Comment 5

[Gre0]

(In reply to Jan Horak [:jhorak] from comment #4)

This is because the Clear recent history dialog is modal. It's always 'above' the Time range to clear dropdown (dropdown does not receive the OnEnterNotify). Setting dropdown menu be also modal somehow workaround the problem but another occurs: You cannot close the dropdown by clicking back to Clear history window.

It seems to be related on how we're creating the popup menus. I need to investigate further the GTK3 code to find some solution - or reproduce it upstream.

As i mentioned in my bug report https://bugzilla.mozilla.org/show_bug.cgi?id=1650611#c3 the Flatpak Version works fine. Also there is no problem in the 'Clear history window' Dialog.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Looks like the history dialog is reworked in latest nightly and no longer uses Gtk widgets.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

It's fixed by bookmark code rewrite in latest nightly.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1621660 [Wayland] When parent window is modal, set modal popup child window too, r?jhorak

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d390cf3d072
[Wayland] When parent window is modal, set modal popup child window too, r=jhorak

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0d390cf3d072