1605852 - enable modernize-concat-nested-namespaces at review phase

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, enhancement)

Description

[Sylvestre Ledru [:Sylvestre]]

which requires C++17 support...

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1605852 - Run clang-tidy with C++17 support r?andi

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1605852 - Enable modernize-concat-nested-namespaces r?andi

Depends on D58190

Comment 3

[Sylvestre Ledru [:Sylvestre]]

I improved upstream doc: https://github.com/llvm/llvm-project/commit/8131c04836829e7f37f2feaa1d85b4ef62ad092f

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c33257156a2
Run clang-tidy with C++17 support r=andi
https://hg.mozilla.org/integration/autoland/rev/70ee38a87597
Enable modernize-concat-nested-namespaces r=andi

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1605852 - Disable performance-inefficient-algorithm as the test isn't C++17 ready r=andi

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Error https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283205546&repo=autoland&lineNumber=1725
Caused by:
https://github.com/llvm/llvm-project/blob/95fe54931fddccccf9740b3247219e30504da447/clang-tools-extra/test/clang-tidy/checkers/performance-inefficient-algorithm.cpp#L2

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cf5cfb1e151
Disable performance-inefficient-algorithm as the test isn't C++17 ready r=andi CLOSED TREE

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4c33257156a2
https://hg.mozilla.org/mozilla-central/rev/70ee38a87597
https://hg.mozilla.org/mozilla-central/rev/3cf5cfb1e151