1605934 - Use nested namespaces - new feature of C++17

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

This replaces

namespace mozilla {
namespace a11y {

by

namespace mozilla::a11y {

I run clang-format to replace the end of the namespace:

}  // namespace Telemetry
}  // namespace mozilla

by

}  // namespace mozilla::Telemetry

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1605934 - Use nested namespaces r?ehsan

This is a new feature of C++17

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1605934 - Use nested namespaces r?ehsan

Done with:
./mach static-analysis check --checks="-*, modernize-concat-nested-namespaces" --fix .
and then clang-format on the files

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbb39655cf71
Use nested namespaces r=sg

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset bbb39655cf71 (bug 1605934) for build bustage in widget/gtk/mozwayland/mozwayland.c

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=285496150&repo=autoland&lineNumber=45976

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=285496112&revision=bbb39655cf717165e956e844ccff83c3456b4e56

Backout:
https://hg.mozilla.org/integration/autoland/rev/29265c40e70287d999ca9cb7e4502c1568fa833a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/633a2d3af5fa
Use nested namespaces r=sg

Comment 6

[Sylvestre Ledru [:Sylvestre]]

ok, thanks
I removed this file from the change

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/633a2d3af5fa

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Landed!

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1605934 - Add nested namespaces in the C++ coding style r?sg,ehsan

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0860e1962a65
Add nested namespaces in the C++ coding style r=sg

Comment 11

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/0860e1962a65