Closed
Bug 1605874
Opened 5 years ago
Closed 5 years ago
nsFrame.cpp: Remove a nested redundant #if
Categories
(Developer Infrastructure :: Lint and Formatting, task, P3)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox74 fixed)
RESOLVED
FIXED
mozilla74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: chrismichaels84, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1600554 +++
Filling as a good first bug to learn workflows.
DEBUG is checked twice and we are in the same block
https://searchfox.org/mozilla-central/source/layout/generic/nsFrame.cpp#11420
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-preprocessor.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
|
Assignee | |
Comment 1•5 years ago
|
||
Just commenting that I am downloading the source now, and am excited to take this as my first bug to validate my understanding of the workflow.
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → chrismichaels84
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/398b5e6b2dab
nsFrame.cpp: Remove a nested redundant #if. r=sylvestre
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•