1605888 - Intermittent browser/components/urlbar/tests/browser/browser_urlbar_event_telemetry.js | Uncaught exception - Waiting for top sites to be updated - threw exception: TypeError: sites[0] is undefined

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=282524533&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/WT5M1zuVT-CeRLpOi02G4w/runs/0/artifacts/public/logs/live_backing.log

---

[task 2019-12-24T18:27:17.103Z] 18:27:17 INFO - TEST-START | browser/components/urlbar/tests/browser/browser_urlbar_event_telemetry.js
[task 2019-12-24T18:27:29.693Z] 18:27:29 INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_urlbar_event_telemetry.js | extra[selIndex] must match in event urlbar#engagement#click. - "0" matches "0" -
[task 2019-12-24T18:27:29.694Z] 18:27:29 INFO - Running test at index 20
[task 2019-12-24T18:27:29.694Z] 18:27:29 INFO - With pageproxystate=invalid, open the panel with openViewOnFocus, Enter.
[task 2019-12-24T18:27:29.694Z] 18:27:29 INFO - Buffered messages finished
[task 2019-12-24T18:27:29.694Z] 18:27:29 INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_urlbar_event_telemetry.js | Uncaught exception - Waiting for top sites to be updated - threw exception: TypeError: sites[0] is undefined
[task 2019-12-24T18:27:29.694Z] 18:27:29 INFO - Leaving test bound test
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - Console message: [JavaScript Error: "getScreenshot(http://example.org/) failed: TypeError: NetworkError when attempting to fetch resource." {file: "resource://activity-stream/lib/Screenshots.jsm" line: 59}]
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - getScreenshotForURL@resource://activity-stream/lib/Screenshots.jsm:59:10
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - asyncmaybeCacheScreenshot@resource://activity-stream/lib/Screenshots.jsm:112:37
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - _fetchScreenshot@resource://activity-stream/lib/TopSitesFeed.jsm:527:23
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - _fetchIcon@resource://activity-stream/lib/TopSitesFeed.jsm:515:16
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - getLinksWithDefaults@resource://activity-stream/lib/TopSitesFeed.jsm:408:16
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - asyncrefresh@resource://activity-stream/lib/TopSitesFeed.jsm:431:30
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - asyncinit@resource://activity-stream/lib/TopSitesFeed.jsm:123:10
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - onAction@resource://activity-stream/lib/TopSitesFeed.jsm:767:14
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - initFeed@resource://activity-stream/lib/Store.jsm:81:12
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - onPrefChanged@resource://activity-stream/lib/Store.jsm:109:14
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - observer@resource://activity-stream/lib/ActivityStreamPrefs.jsm:33:16
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - _setPref@resource://specialpowers/SpecialPowersParent.jsm:516:31
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - _applyPrefs@resource://specialpowers/SpecialPowersParent.jsm:406:14
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - pushPrefEnv/<@resource://specialpowers/SpecialPowersParent.jsm:492:12
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - doPrefEnvOp@resource://specialpowers/SpecialPowersParent.jsm:65:12
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - pushPrefEnv@resource://specialpowers/SpecialPowersParent.jsm:437:12
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - receiveMessage@resource://specialpowers/SpecialPowersParent.jsm:647:21
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - JSWindowActor querypushPrefEnv@resource://specialpowers/SpecialPowersChild.jsm:1040:16
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - updateTopSites@chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/head.js:59:23
[task 2019-12-24T18:27:29.695Z] 18:27:29 INFO - addTopSite@chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_urlbar_event_telemetry.js:838:9
[task 2019-12-24T18:27:29.696Z] 18:27:29 INFO - asynctests<@chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_urlbar_event_telemetry.js:557:11
[task 2019-12-24T18:27:29.696Z] 18:27:29 INFO - test@chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_urlbar_event_telemetry.js:820:33
[task 2019-12-24T18:27:29.696Z] 18:27:29 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2019-12-24T18:27:29.696Z] 18:27:29 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2019-12-24T18:27:29.696Z] 18:27:29 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2019-12-24T18:27:29.696Z] 18:27:29 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67
[task 2019-12-24T18:27:29.696Z] 18:27:29 INFO -
[task 2019-12-24T18:27:30.168Z] 18:27:30 INFO - GECKO(32) | [Parent 4980, Main Thread] WARNING: Suboptimal indexes for the SQL statement 0x1ed3fe88120 (http://mzl.la/1FuID0j).: file z:/build/build/src/storage/mozStoragePrivateHelpers.cpp, line 106
[task 2019-12-24T18:27:30.206Z] 18:27:30 INFO - TEST-FAIL | browser/components/urlbar/tests/browser/browser_urlbar_event_telemetry.js | Assertion count 12 is greater than expected range 0-0 assertions. -
[task 2019-12-24T18:27:30.227Z] 18:27:30 INFO - [7376, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 167
[task 2019-12-24T18:27:30.227Z] 18:27:30 INFO - [7376, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 167

Comment 1

[Razvan Maries]

I think https://hg.mozilla.org/integration/autoland/rev/f6a7e3d2a753 is the culprit.

Harry, could you take a look?

Comment 2

[Intermittent Failures Robot]

15 failures in 95 pushes (0.158 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 7
• mozilla-central: 7
• try: 1

Platform breakdown:

• macosx1014-64: 4
• windows7-32: 4
• linux64: 4
• windows10-64-qr: 2
• windows10-64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1605888&startday=2019-12-25&endday=2019-12-25&tree=all

Comment 3

[Intermittent Failures Robot]

19 failures in 304 pushes (0.062 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 13
• mozilla-central: 6

Platform breakdown:

• windows7-32: 3
• linux64: 8
• windows10-64-qr: 4
• windows10-64-ccov: 1
• macosx1014-64: 1
• windows10-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1605888&startday=2019-12-27&endday=2019-12-27&tree=all

Comment 4

[Intermittent Failures Robot]

64 failures in 1365 pushes (0.047 failures/push) were associated with this bug in the last 7 days.

This is the #8 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 35
• mozilla-central: 24
• try: 5

Platform breakdown:

• windows7-32: 13
• windows10-64-qr: 11
• linux64: 24
• macosx1014-64: 7
• windows10-64: 3
• windows10-64-ccov: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1605888&startday=2019-12-23&endday=2019-12-29&tree=all

Comment 5

[Harry Twyford]

Attachment: Bug 1605888 - Resolve Urlbar Top Sites testing async issue. r?mikedeboer

The tests for Top Sites on new tab check the condition sites && sites[index] && sites[index].condition. I forgot the middle one.

Also, I expect this will also resolve Bug 1605940.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df82822870af
Resolve Urlbar Top Sites testing async issue. r=mikedeboer

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/df82822870af

Comment 8

[Intermittent Failures Robot]

9 failures in 1862 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• mozilla-central: 4

Platform breakdown:

• macosx1014-64: 2
• linux64: 3
• windows10-64-ccov: 2
• windows7-32: 1
• windows10-64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1605888&startday=2019-12-30&endday=2020-01-05&tree=all

Comment 9

[Intermittent Failures Robot]

1 failures in 4004 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1605888&startday=2020-01-20&endday=2020-01-26&tree=all