160589 - make GTK2 port support NO_X11

Status: RESOLVED INVALID

(Core :: XUL, enhancement)

Description

[Eric Warmenhoven]

Since GTK2 can have GDK targets other than X11 (such as linux framebuffer), in 
a perfect world mozilla shouldn't assume that just because it's using GTK2 it 
can therefore use X11.

Comment 1

[Eric Warmenhoven]

Attachment: Beginnings of Mozilla/Gtk2 without X11

I've attached a patch for configure.in and widget/src/gtk2 that removes some
assumptions (and in widget/src/gtk2, uses GDK equivalents of some X11
functions).

Comment 2

[John Morrison]

-> blizzard

Comment 3

[timeless]

+#if !(NO_X11)
+    // XXX: how do we do this without using xlib?
+    // there doesn't seem to be a gdk equivalent of XCheckWindowEvent

you should use #ifndef NO_X11 not #if ...NO_X11
/modules/plugin/base/public/npapi.h, line 308 -- #ifndef NO_X11
/netwerk/protocol/http/src/nsHttpHandler.cpp, line 1167 -- #elif defined(NO_X11)

for this specific fragment, please consider adding an NS_WARNING/NS_ASSERTION
notyetimplemented or something.

Comment 4

[Eric Warmenhoven]

Attachment: Revised preliminary patch

I'm reattaching the patch using #ifndef NO_X11 instead.

It's not that the part that's getting removed by this isn't implemented; it's
just that if you're not using X11 it won't be optimized. I'm not even sure it's
possible to optimize it if you're using the linux-fb gdk backend; I don't know
about the DirectFB backend.

Comment 5

[Karunakaran A]

Apart from the direct calls found in widget/ and toolkits/.... we also have direct calls in gfx/src/gtk/..
  Because of this dependency on X, it is difficult to compile the code on a GTK which is not using X as backend, like DirectFB etc...

Comment 6

[Mats Palmgren (inactive)]

I see that we have code that is #ifdef MOZ_X11 or #ifdef MOZ_DFB under widget/
so is this bug already fixed?

Comment 7

[Jonathan Watt [:jwatt]]

Closing GTK2 related bugs since we removed GTK2 support at the beginning of 2018 in bug 1278282. Probably best to open a new bug in the unlikely event that any of these are still relevant.