1606018 - No edit context menu for Folder name in Edit Bookmarks Panel

Status: VERIFIED FIXED

(Core :: XUL, defect, P2)

Description

[Alice0775 White]

Context menu problem again :(
It seems Mozilla does not provide NO AUTOMATED text for this!

Reproducible: 100%

Steps to reproduce:

1. Click Star button in Address bar
2. Expand Folder Tree view (click on [v] button of the right end)
3. Click on [New Folder] button or double click on existing folder
4. Right click the text field

Actual Results:
No edit context menu popup

Expected Results:
Edit context menu should be available

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=aaeae78fb904b36c896bdf65de199d2e6fffb90e&tochange=10d80ce76790300da30975a3de86dafae5625b76

Comment 1

[Tim Nguyen :ntim]

(In reply to Alice0775 White from comment #0)

Context menu problem again :(
It seems Mozilla does not provide NO AUTOMATED text for this!

Thanks for spotting and reporting this bug! I can reproduce this as well. This is unfortunately 14-year old XUL code that dates back from 2006 (bug 201499), which is why it has poor testing coverage.

Brian, it looks like this condition needs to be extended to take in account anonymous inputs:
https://searchfox.org/mozilla-central/source/toolkit/content/editMenuOverlay.js#98-104

It's a bit tricky because e.target is the tree while e.originalTarget is the anonymous div inside the input. I guess it might be possible to use e.originalTarget.closest() or something like that. I'm worried adding another call for closest() isn't great for perf though...

Anyway, I don't have time to take a closer look until the end of January, is it something you could take a look at after the new year ? Thanks :)

Comment 2

[Alice0775 White]

This is Firefox UI regression. no priority?

Comment 3

[Brian Grinstead [:bgrins]]

Sorry about that, was working through my backlog. I can try to take a look at this before the end of the month, or will sync up with Tim then if not.

Comment 4

[Pascal Chevrel:pascalc (PTO until April 26)]

(In reply to Brian Grinstead [:bgrins] from comment #3)

Sorry about that, was working through my backlog. I can try to take a look at this before the end of the month, or will sync up with Tim then if not.

Brian, any news about it? Thanks

Comment 5

[Tim Nguyen :ntim]

Attachment: Bug 1606018 - Make sure edit context menu also appears on inputs inside shadow trees. r=bgrins,Gijs

Comment 6

[Brian Grinstead [:bgrins]]

(In reply to Pascal Chevrel:pascalc from comment #4)

(In reply to Brian Grinstead [:bgrins] from comment #3)

Sorry about that, was working through my backlog. I can try to take a look at this before the end of the month, or will sync up with Tim then if not.

Brian, any news about it? Thanks

Tim is on it (thanks Tim!).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0e6dad6ff01
Make sure edit context menu also appears on inputs inside shadow trees. r=bgrins

Comment 8

[Alexandru Michis [:malexandru]]

Backed out changeset b0e6dad6ff01 for causing failures in BrowsingContext.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/542f59024db299c10db5faecef1b05b57737dfa3

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&tochange=542f59024db299c10db5faecef1b05b57737dfa3&fromchange=b0e6dad6ff014080801ac2720b2b99c472677751&selectedJob=287806900

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287806900&repo=autoland&lineNumber=5108

[task 2020-02-06T21:23:27.896Z] 21:23:27 INFO - TEST-OK | devtools/client/webconsole/test/browser/browser_webconsole_timestamps.js | took 3745ms
[task 2020-02-06T21:23:27.957Z] 21:23:27 INFO - checking window state
[task 2020-02-06T21:23:27.996Z] 21:23:27 INFO - TEST-START | devtools/client/webconsole/test/browser/browser_webconsole_trackingprotection_errors.js
[task 2020-02-06T21:23:38.303Z] 21:23:38 INFO - GECKO(2864) | console.error: (new TypeError("can't access property "destroy", this._walker is undefined", "resource://devtools/client/accessibility/accessibility-startup.js", 127))
[task 2020-02-06T21:24:05.180Z] 21:24:05 INFO - GECKO(2864) | AddressSanitizer:DEADLYSIGNAL
[task 2020-02-06T21:24:05.188Z] 21:24:05 INFO - GECKO(2864) | =================================================================
[task 2020-02-06T21:24:05.189Z] 21:24:05 ERROR - GECKO(2864) | ==2864==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000158 (pc 0x7fd286e1da7f bp 0x7fffe51bf050 sp 0x7fffe51bedc0 T0)
[task 2020-02-06T21:24:05.190Z] 21:24:05 INFO - GECKO(2864) | ==2864==The signal is caused by a READ memory access.
[task 2020-02-06T21:24:05.191Z] 21:24:05 INFO - GECKO(2864) | ==2864==Hint: address points to the zero page.
[task 2020-02-06T21:24:05.961Z] 21:24:05 INFO - GECKO(2864) | #0 0x7fd286e1da7e in IsContent /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/BrowsingContext.h:269:35
[task 2020-02-06T21:24:05.961Z] 21:24:05 INFO - GECKO(2864) | #1 0x7fd286e1da7e in mozilla::net::LoadInfo::LoadInfo(nsIPrincipal*, nsIPrincipal*, nsINode*, unsigned int, unsigned int, mozilla::Maybe<mozilla::dom::ClientInfo> const&, mozilla::Maybe<mozilla::dom::ServiceWorkerDescriptor> const&, unsigned int) /builds/worker/workspace/build/src/netwerk/base/LoadInfo.cpp:297:41
[task 2020-02-06T21:24:05.969Z] 21:24:05 INFO - GECKO(2864) | #2 0x7fd286ec5583 in mozilla::net::nsIOService::NewChannelFromURIWithProxyFlagsInternal(nsIURI*, nsIURI*, unsigned int, nsINode*, nsIPrincipal*, nsIPrincipal*, mozilla::Maybe<mozilla::dom::ClientInfo> const&, mozilla::Maybe<mozilla::dom::ServiceWorkerDescriptor> const&, unsigned int, unsigned int, unsigned int, nsIChannel**) /builds/worker/workspace/build/src/netwerk/base/nsIOService.cpp:947:20
[task 2020-02-06T21:24:05.969Z] 21:24:05 INFO - GECKO(2864) | #3 0x7fd286ec5448 in mozilla::net::nsIOService::NewChannelFromURIWithClientAndController(nsIURI*, nsINode*, nsIPrincipal*, nsIPrincipal*, mozilla::Maybe<mozilla::dom::ClientInfo> const&, mozilla::Maybe<mozilla::dom::ServiceWorkerDescriptor> const&, unsigned int, unsigned int, unsigned int, nsIChannel**) /builds/worker/workspace/build/src/netwerk/base/nsIOService.cpp:908:10
[task 2020-02-06T21:24:05.990Z] 21:24:05 INFO - GECKO(2864) | #4 0x7fd286efb6d5 in NS_NewChannelInternal(nsIChannel**, nsIURI*, nsINode*, nsIPrincipal*, nsIPrincipal*, mozilla::Maybe<mozilla::dom::ClientInfo> const&, mozilla::Maybe<mozilla::dom::ServiceWorkerDescriptor> const&, unsigned int, unsigned int, nsICookieSettings*, mozilla::dom::PerformanceStorage*, nsILoadGroup*, nsIInterfaceRequestor*, unsigned int, nsIIOService*, unsigned int) /builds/worker/workspace/build/src/netwerk/base/nsNetUtil.cpp:377:20
[task 2020-02-06T21:24:05.990Z] 21:24:05 INFO - GECKO(2864) | #5 0x7fd286efcb6d in NS_NewChannel(nsIChannel**, nsIURI*, nsINode*, unsigned int, unsigned int, mozilla::dom::PerformanceStorage*, nsILoadGroup*, nsIInterfaceRequestor*, unsigned int, nsIIOService*, unsigned int) /builds/worker/workspace/build/src/netwerk/base/nsNetUtil.cpp:504:10
[task 2020-02-06T21:24:06.006Z] 21:24:06 INFO - GECKO(2864) | #6 0x7fd28d4bcc85 in mozilla::dom::(anonymous namespace)::ChannelFromScriptURL(nsIPrincipal*, mozilla::dom::Document*, mozilla::dom::WorkerPrivate*, nsILoadGroup*, nsIIOService*, nsIScriptSecurityManager*, nsIURI*, mozilla::Maybe<mozilla::dom::ClientInfo> const&, mozilla::Maybe<mozilla::dom::ServiceWorkerDescriptor> const&, bool, mozilla::dom::WorkerScriptType, unsigned int, unsigned int, nsICookieSettings*, nsIReferrerInfo*, nsIChannel**) /builds/worker/workspace/build/src/dom/workers/ScriptLoader.cpp:206:10
[task 2020-02-06T21:24:06.006Z] 21:24:06 INFO - GECKO(2864) | #7 0x7fd28d4e3c41 in mozilla::dom::(anonymous namespace)::ScriptLoaderRunnable::LoadScript(unsigned int) /builds/worker/workspace/build/src/dom/workers/ScriptLoader.cpp:997:12
[task 2020-02-06T21:24:06.007Z] 21:24:06 INFO - GECKO(2864) | #8 0x7fd28d4e09bb in RunInternal /builds/worker/workspace/build/src/dom/workers/ScriptLoader.cpp:876:23
[task 2020-02-06T21:24:06.008Z] 21:24:06 INFO - GECKO(2864) | #9 0x7fd28d4e09bb in mozilla::dom::(anonymous namespace)::ScriptLoaderRunnable::Run() /builds/worker/workspace/build/src/dom/workers/ScriptLoader.cpp:626:19
[task 2020-02-06T21:24:06.015Z] 21:24:06 INFO - GECKO(2864) | #10 0x7fd286c79098 in nsThread::ProcessNextEvent(bool, bool*) /builds/worker/workspace/build/src/xpcom/threads/nsThread.cpp:1220:14
[task 2020-02-06T21:24:06.015Z] 21:24:06 INFO - GECKO(2864) | #11 0x7fd286c83eac in NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/workspace/build/src/xpcom/threads/nsThreadUtils.cpp:486:10
[task 2020-02-06T21:24:06.023Z] 21:24:06 INFO - GECKO(2864) | #12 0x7fd287ca949a in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /builds/worker/workspace/build/src/ipc/glue/MessagePump.cpp:87:21
[task 2020-02-06T21:24:06.031Z] 21:24:06 INFO - GECKO(2864) | #13 0x7fd287bde597 in RunInternal /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:315:10
[task 2020-02-06T21:24:06.031Z] 21:24:06 INFO - GECKO(2864) | #14 0x7fd287bde597 in RunHandler /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:308:3
[task 2020-02-06T21:24:06.031Z] 21:24:06 INFO - GECKO(2864) | #15 0x7fd287bde597 in MessageLoop::Run() /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:290:3
[task 2020-02-06T21:24:06.032Z] 21:24:06 INFO - GECKO(2864) | #16 0x7fd28dbc78e8 in nsBaseAppShell::Run() /builds/worker/workspace/build/src/widget/nsBaseAppShell.cpp:137:27
[task 2020-02-06T21:24:06.032Z] 21:24:06 INFO - GECKO(2864) | #17 0x7fd2911164ab in nsAppStartup::Run() /builds/worker/workspace/build/src/toolkit/components/startup/nsAppStartup.cpp:272:30
[task 2020-02-06T21:24:06.039Z] 21:24:06 INFO - GECKO(2864) | #18 0x7fd29132c1f1 in XREMain::XRE_mainRun() /builds/worker/workspace/build/src/toolkit/xre/nsAppRunner.cpp:4566:22
[task 2020-02-06T21:24:06.040Z] 21:24:06 INFO - GECKO(2864) | #19 0x7fd29132e116 in XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/workspace/build/src/toolkit/xre/nsAppRunner.cpp:4701:8
[task 2020-02-06T21:24:06.040Z] 21:24:06 INFO - GECKO(2864) | #20 0x7fd29132edf3 in XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/workspace/build/src/toolkit/xre/nsAppRunner.cpp:4752:21
[task 2020-02-06T21:24:06.040Z] 21:24:06 INFO - GECKO(2864) | #21 0x55a5f26bf615 in do_main /builds/worker/workspace/build/src/browser/app/nsBrowserApp.cpp:217:22
[task 2020-02-06T21:24:06.040Z] 21:24:06 INFO - GECKO(2864) | #22 0x55a5f26bf615 in main /builds/worker/workspace/build/src/browser/app/nsBrowserApp.cpp:331:16
[task 2020-02-06T21:24:06.088Z] 21:24:06 INFO - GECKO(2864) | #23 0x7fd2a5dcab96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310
[task 2020-02-06T21:24:06.089Z] 21:24:06 INFO - GECKO(2864) | #24 0x55a5f2614c58 in _start (/builds/worker/workspace/build/application/firefox/firefox+0x99c58)
[task 2020-02-06T21:24:06.090Z] 21:24:06 INFO - GECKO(2864) | AddressSanitizer can not provide additional info.
[task 2020-02-06T21:24:06.090Z] 21:24:06 INFO - GECKO(2864) | SUMMARY: AddressSanitizer: SEGV /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/BrowsingContext.h:269:35 in IsContent
[task 2020-02-06T21:24:06.090Z] 21:24:06 INFO - GECKO(2864) | ==2864==ABORTING

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91db369c965a
Make sure edit context menu also appears on inputs inside shadow trees. r=bgrins

Comment 10

[Tim Nguyen :ntim]

The failure wasn't caused by my patch, as the backout showed: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=542f59024db299c10db5faecef1b05b57737dfa3&selectedJob=287813146

It probably just showed up because TV only re-runs tests when they've been changed.

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/91db369c965a

Comment 12

[Alexandra Martin]

The issue is verified as fixed using Windows 10 x64 and Mac 10.14 on Firefox Nightly 74.0a1 (2020-02-07). Flags will be updated accordingly.