1606036 - Implement high contrast mode in GTK.

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1606036 - Implement high contrast mode in GTK. r=stransky,karlt

Over in bug 1604761 I realized that GTK has a high-contrast accessibility
setting, that GTK does not honor the same way as windows does.

There's no good reason for that IMO, and high contrast mode on windows is
getting some love.

This hooks the relevant parts of the GTK widget code so that we also avoid
websites overriding high contrast colors (via PreferenceStyleSheet and co).

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Maybe it should be part of the release notes?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbeea4db8ede
Implement high contrast mode in GTK. r=stransky

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/dbeea4db8ede

Comment 7

[Alex ARNAUD]

Hello Emilio,

Many thanks for working on this.

I'm myself visual-impaired and a user of the high contrast theme of GTK, what should have change? I'm seen no improvement despite I'm using nightly.

Note that on Windows the default high contrast theme for Firefox is not so good because it uses black background whereas it should use white background as lot of user uses the inverse color function because most of the webpage are on white background.

Best regards.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Hmm, it should just work, as long as "about:preferences" > "Colors" has the "Override the colors specified by the page with your selections above" set to "Only with high contrast themes".

If it is not working out of the box I'd be interested in why, what's the name of your GTK theme?

Comment 9

[Alex ARNAUD]

If it is not working out of the box I'd be interested in why, what's the name of your GTK theme?

It works out of the box indeed but IMHO this is not a user improvement but a regression because now users of the high contrast theme see all the issues with this Firefox mode. The main issues regarding this are: images are hidden often like the Facebook logo and it is difficult to differentiate part of a website because border are not respected.
A good example of this is the Firefox preferences where the highlight are not respected at all.

Could we revert this change or change the default Firefox behavior for this? As a visual-impaired person using the high contrast theme I don't want see site differently as others except if I request it.

The default behavior IMHO should be never. Usually low-user who want to improve contrast on website user color filters of the OS or screen magnifier or third-party module like the Dark Mode module that works pretty well.

Best regards.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

There is UI to disable this: about:preferences > Colors > Override the colors specified by the page with your selections above > Never.

It'd be ok to make "Only with high contrast themes" not default, but that's more of a question for the a11y team.