1606046 - Enable CreateContextFlags::PREFER_ROBUSTNESS flag for WebRender GLContextEGL on Windows.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

Created by Bug 1604006 comment 10.

Comment 1

[Sotaro Ikeda [:sotaro]]

When EGL_LOSE_CONTEXT_ON_RESET is set by CreateContextFlags::PREFER_ROBUSTNESS flag, ANGLE avoids to release D3D resources when ANGLE detects device reset.

• https://searchfox.org/mozilla-central/rev/c79fc6e32a5b561205a71fcfef9112d34b4037ae/gfx/angle/checkout/src/libANGLE/Display.cpp#1011

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1606046 - Enable CreateContextFlags::PREFER_ROBUSTNESS flag for WebRender GLContextEGL on Windows

Comment 3

[Sotaro Ikeda [:sotaro]]

Renderer11::resetDevice() calls Renderer11::initialize() after Renderer11::release() call.

• https://searchfox.org/mozilla-central/rev/c79fc6e32a5b561205a71fcfef9112d34b4037ae/gfx/angle/checkout/src/libANGLE/renderer/d3d/d3d11/Renderer11.cpp#1939

But Renderer11::initialize() did not re-allocate Renderer11::mClear. Since Renderer11::initializeD3DDevice() was failed because Renderer11 held obsoleted D3DDevice.

• https://searchfox.org/mozilla-central/rev/c79fc6e32a5b561205a71fcfef9112d34b4037ae/gfx/angle/checkout/src/libANGLE/renderer/d3d/d3d11/Renderer11.cpp#761

D3DDevice was provided by gecko int GetAndInitDisplayForWebRender() , then ANGLE could not re-create D3DDevice.

• https://searchfox.org/mozilla-central/rev/c79fc6e32a5b561205a71fcfef9112d34b4037ae/gfx/gl/GLLibraryEGL.cpp#160

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee75ca9a28cc
Enable CreateContextFlags::PREFER_ROBUSTNESS flag for WebRender GLContextEGL on Windows r=gw

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ee75ca9a28cc