1608235 - Crash in [@ egl::ValidateStreamConsumerGLTextureExternalAttribsNV]

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-1212a2ca-9f2c-43ec-9b91-253540200108.

Seen while looking at nightly crash stats - gpu crashes started in 20200107095722: https://bit.ly/2seGfwY

Possible regression range based on build id: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bc5880b621d585ca49be49e07ee14dd32153c01b&tochange=e728bf01a2b60414e18ac3abed8af55d5ab35924

Top 10 frames of crashing thread:

0 libglesv2.dll egl::ValidateStreamConsumerGLTextureExternalAttribsNV gfx/angle/checkout/src/libANGLE/validationEGL.cpp:2634
1 libglesv2.dll EGL_StreamConsumerGLTextureExternalAttribsNV gfx/angle/checkout/src/libGLESv2/entry_points_egl_ext.cpp:785
2 xul.dll mozilla::wr::RenderDXGITextureHostOGL::EnsureLockable gfx/webrender_bindings/RenderD3D11TextureHostOGL.cpp
3 xul.dll mozilla::wr::RenderDXGITextureHostOGL::Lock gfx/webrender_bindings/RenderD3D11TextureHostOGL.cpp:208
4 xul.dll mozilla::wr::wr_renderer_lock_external_image gfx/webrender_bindings/RendererOGL.cpp:51
5 xul.dll webrender_bindings::bindings::{{impl}}::lock gfx/webrender_bindings/src/bindings.rs:439
6 xul.dll webrender::renderer::Renderer::render_impl gfx/wr/webrender/src/renderer.rs:3102
7 xul.dll webrender::renderer::Renderer::render gfx/wr/webrender/src/renderer.rs:2921
8 xul.dll webrender_bindings::bindings::wr_renderer_render gfx/webrender_bindings/src/bindings.rs:654
9 xul.dll mozilla::wr::RendererOGL::UpdateAndRender gfx/webrender_bindings/RendererOGL.cpp:151

Comment 1

[Kris Taeleman (:ktaeleman)]

@sotaro: This looks like a high frequency crash. I couldn't immediately spot a change that would cause this, but since you changed the logging in https://bugzilla.mozilla.org/show_bug.cgi?id=1607129, I thought you might have some ideas here.

Comment 2

[Sotaro Ikeda [:sotaro]]

OK, I take a look. I wonder if it might be related to device reset.

Comment 3

[Sotaro Ikeda [:sotaro]]

Crash happened at EGL_StreamConsumerGLTextureExternalAttribsNV(). It uses "gl::Context *context = gl::GetValidGlobalContext()" for validation check. The context seemed to be nullptr.

ANGLE has similar checks in the followings.

• EGL_StreamConsumerGLTextureExternalKHR()
• EGL_StreamConsumerAcquireKHR()
• EGL_StreamConsumerReleaseKHR()
• EGL_StreamConsumerGLTextureExternalAttribsNV()

They affects only to

• RenderDXGITextureHostOGL::EnsureLockable()
• RenderDXGIYCbCrTextureHostOGL::EnsureLockable()

When ANGLE detects a context lost, GetValidGlobalContext() returns nullptr.
https://searchfox.org/mozilla-central/rev/c52d5f8025b5c9b2b4487159419ac9012762c40c/gfx/angle/checkout/src/libANGLE/Thread.cpp#99

Comment 4

[Sotaro Ikeda [:sotaro]]

The following does not handle a case that context is nullptr. All another functions seems to have a nullptr check.

• ValidateStreamConsumerGLTextureExternalKHR()
  • https://searchfox.org/mozilla-central/rev/c52d5f8025b5c9b2b4487159419ac9012762c40c/gfx/angle/checkout/src/libANGLE/validationEGL.cpp#2490
• ValidateStreamConsumerGLTextureExternalAttribsNV()
  • https://searchfox.org/mozilla-central/rev/c52d5f8025b5c9b2b4487159419ac9012762c40c/gfx/angle/checkout/src/libANGLE/validationEGL.cpp#2618

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1608235 - Add nullptr check

Comment 6

[Kelsey Gilbert [:jgilbert]]

Bug 1606046 is probably the change that brought us here, but this is a bug we should fix.

Comment 7

[Kelsey Gilbert [:jgilbert]]

https://bugs.chromium.org/p/angleproject/issues/detail?id=4333

Comment 8

[Kelsey Gilbert [:jgilbert]]

https://chromium-review.googlesource.com/c/angle/angle/+/2015838

Comment 9

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1608235 - [ANGLE] Validate `context` before use.

Comment 10

[Kelsey Gilbert [:jgilbert]]

https://github.com/mozilla/angle/tree/firefox-74

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b09849127a4f
[ANGLE] Validate `context` before use. r=sotaro

Comment 12

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b09849127a4f