Change the folder enumeration MailExtension API from a flat list to a hierarchy
Categories
(Thunderbird :: Add-Ons: Extensions API, defect)
Tracking
(Not tracked)
People
(Reporter: protz, Assigned: darktrojan)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
12.05 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
I would like the accounts MailExtension API to preserve the tree-like structure of the folder tree for a given account, rather than require clients to jump through hoops to reconstruct that structure based on string manipulation to split paths in the folder URI.
The attached patch does just that; since it only adds an extra property, I believe the breakage should be close to non-existent and I doubt that anyone relies on this yet.
Thanks,
Jonathan
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Reporter | ||
Comment 2•5 years ago
|
||
My bad -- I somehow thought this hadn't trickled down yet to release. I haven't been following the release cycle very closely.
Reporter | ||
Comment 3•5 years ago
|
||
My claim is that in the current state, the API is not very useful and as such I'm having a hard time imagining that anyone is relying on it.
Assignee | ||
Comment 4•5 years ago
|
||
This change breaks a whole bunch of tests, so I've fixed them and will post a new patch when I've checked the fix is good.
There are a few known users of this API so we can reach out to them and let them know. Fortunately it's possible to make a simple change that will work with both versions. I'd be even more reluctant to do this otherwise.
Assignee | ||
Comment 5•5 years ago
|
||
Comment 6•5 years ago
|
||
Comment on attachment 9119669 [details] [diff] [review] 1606584-accounts-folders-tree-1.diff Review of attachment 9119669 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=mkmelin
Reporter | ||
Comment 7•5 years ago
|
||
Thanks for helping out with this. I guess your suggested change will be to flatten the subFolders
field, if present, for clients who don't need the tree structure?
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 8•5 years ago
|
||
(In reply to Jonathan Protzenko [:protz] from comment #7)
Thanks for helping out with this. I guess your suggested change will be to flatten the
subFolders
field, if present, for clients who don't need the tree structure?
More or less, yes.
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/446e3aafa9b9
When listing accounts, return a tree of folders rather than a flattened list; r=mkmelin
Assignee | ||
Updated•5 years ago
|
Description
•