1606584 - Change the folder enumeration MailExtension API from a flat list to a hierarchy

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Jonathan Protzenko [:protz]]

Attachment: build a tree rather than a flattened list

I would like the accounts MailExtension API to preserve the tree-like structure of the folder tree for a given account, rather than require clients to jump through hoops to reconstruct that structure based on string manipulation to split paths in the folder URI.

The attached patch does just that; since it only adds an extra property, I believe the breakage should be close to non-existent and I doubt that anyone relies on this yet.

Thanks,

Jonathan

Comment 1

[Geoff Lankow (:darktrojan)]

You realise this is already in Thunderbird 68, right?

Comment 2

[Jonathan Protzenko [:protz]]

My bad -- I somehow thought this hadn't trickled down yet to release. I haven't been following the release cycle very closely.

Comment 3

[Jonathan Protzenko [:protz]]

My claim is that in the current state, the API is not very useful and as such I'm having a hard time imagining that anyone is relying on it.

Comment 4

[Geoff Lankow (:darktrojan)]

This change breaks a whole bunch of tests, so I've fixed them and will post a new patch when I've checked the fix is good.

There are a few known users of this API so we can reach out to them and let them know. Fortunately it's possible to make a simple change that will work with both versions. I'd be even more reluctant to do this otherwise.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: 1606584-accounts-folders-tree-1.diff

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9119669 [details] [diff] [review]
1606584-accounts-folders-tree-1.diff

Review of attachment 9119669 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 7

[Jonathan Protzenko [:protz]]

Thanks for helping out with this. I guess your suggested change will be to flatten the subFolders field, if present, for clients who don't need the tree structure?

Comment 8

[Geoff Lankow (:darktrojan)]

(In reply to Jonathan Protzenko [:protz] from comment #7)

Thanks for helping out with this. I guess your suggested change will be to flatten the subFolders field, if present, for clients who don't need the tree structure?

More or less, yes.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/446e3aafa9b9
When listing accounts, return a tree of folders rather than a flattened list; r=mkmelin