1606659 - Cleanup nsFrameLoader::Show and related to make extending it easier.

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1606659 - Don't pass margin and scrollbar preferences to nsFrameLoader::Show. r=mattwoodrow

Instead, get them on the relevant code paths.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1606659 - Make Browser*::Show take two arguments, one from the parent process, one from the owner of the frame. r=mattwoodrow

This makes clear where the information comes from, and also that there are some
bits of information that we should pass down from the child that we don't, like
allowfullscreen and the frame name.

Depends on D58534

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/887a302a5c9b
Don't pass margin and scrollbar preferences to nsFrameLoader::Show. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/1798281cc4df
Make Browser*::Show take two arguments, one from the parent process, one from the owner of the frame. r=mattwoodrow

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1606659 - Fix a subtle behavior difference from the first patch in this bug. r=mattwoodrow

We should check which conditions in here can and cannot happen, as try was
pretty green without this change...

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6235e885b079
Fix a subtle behavior difference from the first patch in this bug. r=mattwoodrow

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/887a302a5c9b
https://hg.mozilla.org/mozilla-central/rev/1798281cc4df
https://hg.mozilla.org/mozilla-central/rev/6235e885b079