Closed Bug 1606659 Opened 3 years ago Closed 3 years ago

Cleanup nsFrameLoader::Show and related to make extending it easier.

Categories

(Core :: DOM: Content Processes, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(3 files)

No description provided.
Blocks: 1588791
Blocks: 1606660
Assignee: nobody → emilio
Status: NEW → ASSIGNED

This makes clear where the information comes from, and also that there are some
bits of information that we should pass down from the child that we don't, like
allowfullscreen and the frame name.

Depends on D58534

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/887a302a5c9b
Don't pass margin and scrollbar preferences to nsFrameLoader::Show. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/1798281cc4df
Make Browser*::Show take two arguments, one from the parent process, one from the owner of the frame. r=mattwoodrow

We should check which conditions in here can and cannot happen, as try was
pretty green without this change...

Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6235e885b079
Fix a subtle behavior difference from the first patch in this bug. r=mattwoodrow
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Regressions: 1607113
Regressions: 1607112
You need to log in before you can comment on or make changes to this bug.