Closed
Bug 1606680
Opened 6 years ago
Closed 6 years ago
Remove remaining internal uses of mTabContainer
Categories
(SeaMonkey :: Tabbed Browser, task)
SeaMonkey
Tabbed Browser
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey 2.71
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
(Blocks 1 open bug)
Details
(Whiteboard: SM2.53.2)
Attachments
(1 file)
|
1.41 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Most internal uses of mTabContainer were removed in bug 577756, but there are two places left:
https://dxr.mozilla.org/comm-esr60/search?q=this.mTabContainer+path%3Asuite&redirect=false
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.2
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none
Attachment #9118381 -
Flags: review?(frgrahl)
Attachment #9118381 -
Flags: approval-comm-release?
Attachment #9118381 -
Flags: approval-comm-esr60?
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9118381 [details] [diff] [review]
Switch to tabContainer
lgtm
Attachment #9118381 -
Flags: review?(frgrahl)
Attachment #9118381 -
Flags: review+
Attachment #9118381 -
Flags: approval-comm-release?
Attachment #9118381 -
Flags: approval-comm-release+
Attachment #9118381 -
Flags: approval-comm-esr60?
Attachment #9118381 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/d56158f2a592
Remove remaining internal uses of mTabContainer. r=frg
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
||
Updated•6 years ago
|
Target Milestone: --- → seamonkey 2.71
You need to log in
before you can comment on or make changes to this bug.
Description
•