1607041 - Extend tabbrowser to allow vertical display of tabs.

Status: NEW

(SeaMonkey :: Tabbed Browser, enhancement)

Description

[bblack]

There is no extension that allows this in Seamonkey without errors.
The problem is the drag-drop mechanism and other things.

Comment 1

[bblack]

Attachment: 1607041-vertical-tab-browser-253.patch

Testet with SM 2.53.1 and 2.53.2 beta 1 pre Build-Identifikator: 20191231130007

Comment 2

[bblack]

Attachment: 1607041-icons.zip

icons

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9118756 [details] [diff] [review]
1607041-vertical-tab-browser-253.patch

Hi, diy you try this with the modern theme? Seems there is no styling information in it for this one. I can check out how it is with macOS but probably needs some additonal love here too. I think it should also be exposed in the preferences. Best to add a second patch for this here to or we do it later.
 
For new icons we would prefer svg so that they scale on hi-dpi displays but might be a bit hard. Could you convert the icons to png at least. 

I will try out the patch later but these two are first impressions. Thanks for bringing this back.

Comment 4

[Frank-Rainer Grahl (:frg)]

Added stefanh to take a look at the macOS side.

Comment 5

[bblack]

Attachment: 1607041-vertical-tab-browser-257.patch

not yet tested with sm 2.57

Comment 7

[bblack]

So far only tested under win10.
Currently I have no possibility to test under mac or Linux. But it should work independently of the operating system. But there might be some optical improvements necessary.

Comment 8

[Frank-Rainer Grahl (:frg)]

Currently I have no possibility to test under mac or Linux.

No problem. Just the Modern theme needs to be updated in any case.

Comment 9

[bblack]

(In reply to Frank-Rainer Grahl (:frg) from comment #3)

Comment on attachment 9118756 [details] [diff] [review]
1607041-vertical-tab-browser-253.patch

Hi, diy you try this with the modern theme?

Yes, I have tested it under modern theme and found that it does not work at all.
Then I reworked the tabbrowser again, so that the most important settings are implemented in js and not in css (orient, alignment, height, width...), so that it should now work with other themes, not only modern.
But there might be some optical improvements necessary.

Comment 10

[bblack]

use:
The switching between vertical and horizontal tabs can be done on the fly.
No restart is necessary and no adjustments have to be made.
It is enough to drag a tab to the right or left and drop it.

Comment 11

[bblack]

I tried to keep the changes as small as possible (only if statements on horizontal/vertical) if you don't want to use vertical tabs.
Only the code of tabbrowser.xml was changed, not tabbox.xml and others.
Maybe this makes the code a bit more complicated at some points, but this should prevent other extensions from being affected.

Comment 12

[bblack]

(In reply to Frank-Rainer Grahl (:frg) from comment #3)

Comment on attachment 9118756 [details] [diff] [review]
1607041-vertical-tab-browser-253.patch

For new icons we would prefer svg so that they scale on hi-dpi displays but
might be a bit hard. Could you convert the icons to png at least.

I have derived the icons from the existing ones. "tab-arrow-down" is a rotated version of "tab-arrow-right" and so on.
Shouldn't I then convert the others in this directory to png as well?
But then I would have to adapt the code because of the changed file names.

Comment 13

[bblack]

Attachment: 1607041-vertical-tab-browser-253.patch

Same procedure as every day.
You have to look carefully when using copy and paste.

Comment 14

[bblack]

Attachment: 1607041-vertical-tab-browser-257.patch

and here the second one.

Comment 15

[Stefan [:stefanh]]

I haven't tried the patch, but Mac tabs uses different styling, so we'll probably need separate Mac styling.

Comment 16

[bblack]

Attachment: tabbrowser.xml

I found no differences in the way the tab browser works between 2.53 and 2.57.
If Bug 1606681, Bug 1607025, Bug 1606680, Bug 1607023
and Bug 1430386 (Rename mTabstrip to arrowScrollbox) are ported to version 2.53, both tabbrowser.xml versions should be identical.
I have tested the tabbrowser.xml file from the last 2.57 version with my patch and the others together in SM2.53.2 and could not find any errors.
I have uploaded this version.

Comment 17

[bblack]

One more note on behaviour:
In each window the tab bar can be used differently, independent of each other.
The horizontal/vertical and right/left behaviour is only stored once and not for each window separately in the session store.
This means that new windows will be opened in the same way as the last time the tab bar was changed.
The same applies to all windows on restart.
I think this is not a problem as most people prefer a certain orientation. But this has the advantage that even when used vertically you can temporarily switch a window to horizontal without having to restart or adjust settings if you need a wider display.

Comment 18

[bblack]

Attachment: 1607041-vertical-tab-browser.patch

Updated patch, should work for 2.53 and 2.57 if the dependent patches were applied.
A small bug has been fixed and optimized for modern theme.

Comment 19

[Frank-Rainer Grahl (:frg)]

bblack. I am a bit busy this week. Will see that I look into it during the weekend.

Comment 20

[bblack]

Attachment: 1607041-vertical-tab-browser V1.1

The previous patch also contains the "Depends on" patches. This one is without them.

Comment 21

[bblack]

Attachment: tabbrowser.xml

Comment 22

[Frank-Rainer Grahl (:frg)]

Attachment: 1607041-vertical-tab-browser_V2-253.patch

Hi. The new css and cons are not packed. I also needed to rebase the patch to take the updated bug 625114 into account. I will test it later. Could you check if this is containing everything.

Comment 23

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9119132 [details] [diff] [review]
1607041-vertical-tab-browser.patch

jar.mn copying is mssing. See V2 patch.

Comment 24

[bblack]

(In reply to Frank-Rainer Grahl (:frg) from comment #22)

Created attachment 9120294 [details] [diff] [review]
1607041-vertical-tab-browser_V2-253.patch

Could you check if this is containing everything.

Looks good to me.

Comment 25

[Frank-Rainer Grahl (:frg)]

Attachment: macOS horizontal tabs (with SeaTab X 2)

Comment 26

[Frank-Rainer Grahl (:frg)]

Attachment: macOS vertical tabs (with SeaTab X 2)

macOS does not look too bad. The arrows are wrong and the styling has minor problems. See first icon which is shifted and it seems to have part of the horizontal borders (Same in Windows).

My CSS is not really good. Maybe stefanh can make some suggestions. But it seems to work at least.

Comment 27

[bblack]

I have a workarround for Bug 1609903, but it is quite ugly.
The missing of event.relatedTarget also causes additional errors in the tabbrowser.

Comment 28

[Frank-Rainer Grahl (:frg)]

Backport Bug 1389274 and friends

Comment 29

[Frank-Rainer Grahl (:frg)]

Bug 1389274 Bug 1416391 backported to 2.53.2 unofficial . Probably too late for today.

Comment 30

[bblack]

FRG: Danke, funktioniert.

Comment 31

[Frank-Rainer Grahl (:frg)]

Hi,
any news here? A few tabbrowser changes landed which probably affected this. The current unofficial queue should be near final 2.53.2 beta 1.
It would be great if we could make this pref controlled and integrate it.

Comment 32

[Frank-Rainer Grahl (:frg)]

no further progress unassigning