1606744 - Japanese fonts name MOJIBAKE and indicates English font name in preferences and Thunderbird Compose window.

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Alice0775 White]

Attachment: screebshot

Reproducible: always

Steps To Reproduce:

1. Make sure that Windows display language is Japanese on Windows 10
2. about:preferences > Font & Color dropdown
   or about:preferences > Advanced dropdown

Actual Results:
MOJIBAKE Font name

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=08d68f49cc423b9d0ca67955e2023b8943f0d22a&tochange=af71a7b69a5e947be09494bbdb33cdc15c4ef343

Comment 2

[Alice0775 White]

Attachment: Thunderbird 73.0a1 compose window

Thunderbird is also affected.

Comment 3

[Alice0775 White]

[Tracking Requested - why for this release]: Some Japanese font name MOJIBAKE in preferences and Thunderbird Compose window

Comment 4

[Alice0775 White]

FYI, if you have EPSON Printer, you can download and install it from https://www.epson.jp/dl_soft/readme/9296.htm

Comment 5

[Alice0775 White]

Attachment: screenshot, indicates English font name not Japanese font name

Comment 6

[Alice0775 White]

[Tracking Requested - why for this release]:Some Japanese font name MOJIBAKE and English name in preferences and Thunderbird Compose window

Comment 7

[Alice0775 White]

Attachment: screenshot2, indicates English font name not Japanese font name

Comment 8

[Jonathan Kew [:jfkthame]]

Weird. Yes, I can reproduce this after installing the Epson fonts (with their Japanese names).... will investigate what may be happening.

Comment 9

[Jonathan Kew [:jfkthame]]

The problem seems to be that the GlobalizationPreferences API is giving us a plain "ja" as the first language code, but this fails when it is used in gfxDWriteFontFamily::LocalizedName to get the font's localized name.

To work around the issue, we can use the Locale class to find the appropriate default region subtag to go with such a language code. This then matches the locale code we used to get via GetUserPreferredUILanguages, and works properly with DirectWrite to access font names.

Comment 10

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1606744 - Add a default region subtag to the system locale code if GlobalizationPreferences returns a bare language code, to avoid problems with DirectWrite localized font-name API. r=emk

Comment 11

[Jonathan Kew [:jfkthame]]

This fixes the problem in my local build; I've also started a tryserver build at https://treeherder.mozilla.org/#/jobs?repo=try&revision=89e49f4b7ed2a5ed2419b5bb832f3fbef6776add. When this is ready, if you could confirm it resolves the issue that would be really helpful.

It's late in the beta cycle, but we should probably try to uplift this to 72 once the fix is confirmed.

Comment 12

[Julien Cristau [:jcristau] (back August 5)]

I can keep this on the radar for a possible dot release but for 72.0 I'm afraid it's too late.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/410d6845491d
Add a default region subtag to the system locale code if GlobalizationPreferences returns a bare language code, to avoid problems with DirectWrite localized font-name API. r=emk

Comment 14

[Alice0775 White]

(In reply to Jonathan Kew (:jfkthame) from comment #11)

This fixes the problem in my local build; I've also started a tryserver build at https://treeherder.mozilla.org/#/jobs?repo=try&revision=89e49f4b7ed2a5ed2419b5bb832f3fbef6776add. When this is ready, if you could confirm it resolves the issue that would be really helpful.

I confirmed that the try build(https://hg.mozilla.org/try/rev/89e49f4b7ed2a5ed2419b5bb832f3fbef6776add) fixed this issue on Windows10.

Comment 15

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/410d6845491d

Comment 16

[Julien Cristau [:jcristau] (back August 5)]

Jonathan do you think this is worth taking in a dot release for 72 (in which case please request uplift to release), or can it ride the trains to 73 (which ships in a month)?

Comment 17

[Jonathan Kew [:jfkthame]]

I think that given the minimal risk here, and the ugly/illegible result of the bug for the affected font names on Japanese systems, it'd be worth taking this in a dot release.

Comment 18

[Jonathan Kew [:jfkthame]]

Comment on attachment 9118547 [details]
Bug 1606744 - Add a default region subtag to the system locale code if GlobalizationPreferences returns a bare language code, to avoid problems with DirectWrite localized font-name API. r=emk

Beta/Release Uplift Approval Request

• User impact if declined: Japanese fonts with localized names show illegible garbage in the Preferences menu
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The only change is to append a default region code to a locale name on Windows; no possible impact on other platforms, or on any locale where Windows already includes a region. This better matches what the previous APIs were returning, so there is no significant risk to consumers of the locale code.
• String changes made/needed:

Comment 19

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Reproduced the issue on Firefox 72.0 under Windows 10. The issue is fixed on 73.0b4. Will verify it on 72 too when the fix is approved.

Comment 20

[Julien Cristau [:jcristau] (back August 5)]

Comment on attachment 9118547 [details]
Bug 1606744 - Add a default region subtag to the system locale code if GlobalizationPreferences returns a bare language code, to avoid problems with DirectWrite localized font-name API. r=emk

fixing a regression with font names in preferences, approved for 72.0.2

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/8385ca17685a

Comment 22

[Catalin Sasca, Desktop Test Engineering [:csasca]]

This is fixed on 72.0.2 as well.