Closed Bug 1606785 (prettier-css-format) Opened 5 years ago Closed 2 months ago

Use Prettier for formatting CSS files

Categories

(Developer Infrastructure :: Lint and Formatting, task, P3)

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: Honza, Unassigned)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

It would be great to have unified style formatting for all DevTools CSS files.

  • Consistency across our code base
  • Easier reviews
  • IDE integrations (e.g. VS Code docs)
  • Automation through ./mach eslint

WDYT?

Honza

What about doing it on the whole tree?

Component: General → Lint and Formatting
Product: DevTools → Firefox Build System

Victor, I believe we talked about this when we discussed prettier. What do you think about linting CSS in devtools or all of tree?

Flags: needinfo?(vporof)
See Also: → 1508369
See Also: → 1561001

Clearing stale needinfo.

If we decide to move forward, we should dupe bug 1508369 to this.

Flags: needinfo?(vporof)

It is being discussed (on the roadmap or not)

See Also: → 1659444
See Also: 1561001
Blocks: css-linting
No longer blocks: prettier-format
Severity: normal → --
Summary: Run prettier for CSS files → Run prettier coding style for CSS files
Summary: Run prettier coding style for CSS files → Use Prettier for formatting CSS files
Alias: prettier-css-format
Product: Firefox Build System → Developer Infrastructure

We are not planning to move forward with this at the moment. There's some summarized context in bug 1921088 comment 2.

Instead we probably want to use the stylistic-stylelint rules rolled out more widely than the new tab code, which gives us some of the same benefits described here.

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: