1606785 - (prettier-css-format) Use Prettier for formatting CSS files

Status: RESOLVED WONTFIX

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

It would be great to have unified style formatting for all DevTools CSS files.

• Consistency across our code base
• Easier reviews
• IDE integrations (e.g. VS Code docs)
• Automation through ./mach eslint

WDYT?

Honza

Comment 1

[Sylvestre Ledru [:Sylvestre]]

What about doing it on the whole tree?

Comment 2

[Jason Laster [:jlast]]

Victor, I believe we talked about this when we discussed prettier. What do you think about linting CSS in devtools or all of tree?

Comment 3

[Andrew Halberstadt [:ahal]]

Clearing stale needinfo.

If we decide to move forward, we should dupe bug 1508369 to this.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

It is being discussed (on the roadmap or not)

Comment 5

[:Gijs (he/him)]

Attachment: content browser.css formatted by prettier

Comment 6

[:Gijs (he/him)]

Attachment: Diff of content browser.css before/after prettier usage

Comment 7

[:Gijs (he/him)]

We are not planning to move forward with this at the moment. There's some summarized context in bug 1921088 comment 2.

Instead we probably want to use the stylistic-stylelint rules rolled out more widely than the new tab code, which gives us some of the same benefits described here.