Closed
Bug 1606785
(prettier-css-format)
Opened 5 years ago
Closed 2 months ago
Use Prettier for formatting CSS files
Categories
(Developer Infrastructure :: Lint and Formatting, task, P3)
Developer Infrastructure
Lint and Formatting
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: Honza, Unassigned)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files)
45.13 KB,
text/css
|
Details | |
44.60 KB,
patch
|
Details | Diff | Splinter Review |
It would be great to have unified style formatting for all DevTools CSS files.
- Consistency across our code base
- Easier reviews
- IDE integrations (e.g. VS Code docs)
- Automation through
./mach eslint
WDYT?
Honza
Comment 1•5 years ago
|
||
What about doing it on the whole tree?
Component: General → Lint and Formatting
Product: DevTools → Firefox Build System
Updated•5 years ago
|
Blocks: prettier-format
Comment 2•5 years ago
|
||
Victor, I believe we talked about this when we discussed prettier. What do you think about linting CSS in devtools or all of tree?
Flags: needinfo?(vporof)
Comment 3•5 years ago
|
||
Clearing stale needinfo.
If we decide to move forward, we should dupe bug 1508369 to this.
Flags: needinfo?(vporof)
Comment 4•5 years ago
|
||
It is being discussed (on the roadmap or not)
Updated•3 years ago
|
Severity: normal → --
Comment 5•3 years ago
|
||
Comment 6•3 years ago
|
||
Updated•3 years ago
|
Summary: Run prettier for CSS files → Run prettier coding style for CSS files
Updated•3 years ago
|
Summary: Run prettier coding style for CSS files → Use Prettier for formatting CSS files
Updated•3 years ago
|
Alias: prettier-css-format
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
Comment 7•2 months ago
|
||
We are not planning to move forward with this at the moment. There's some summarized context in bug 1921088 comment 2.
Instead we probably want to use the stylistic-stylelint rules rolled out more widely than the new tab code, which gives us some of the same benefits described here.
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•