Closed Bug 1606787 Opened 4 years ago Closed 4 years ago

VSCode prettier extension will automatically format CSS files

Categories

(Developer Infrastructure :: Lint and Formatting, task, P3)

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(1 file)

Follow up to discussion in https://phabricator.services.mozilla.com/D58476

It seems that the recommended Prettier extension for VSCode automatically formats CSS.
I guess this is also true for any editor extension that formats on save.

However ./mach lint is not checking CSS formatting issues, and we have not auto-formatted CSS files in the tree.

This can lead to unexpected formatting changes for developers using VSCode. While we discuss enabling prettier for CSS (:honza filed Bug 1606785), maybe we should just exclude CSS files from prettier's configuration until then?

It seems that the recommended Prettier extension for VSCode automatically formats CSS.
I guess this is also true for any editor extension that formats on save.

However ./mach lint is not checking CSS formatting issues, and we have not auto-formatted CSS files in the tree.

This can lead to unexpected formatting changes for developers using VSCode.

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/421a3f911d73
Exclude CSS files from Prettier configuration r=vporof
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: