VSCode prettier extension will automatically format CSS files
Categories
(Developer Infrastructure :: Lint and Formatting, task, P3)
Tracking
(firefox73 fixed)
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
Follow up to discussion in https://phabricator.services.mozilla.com/D58476
It seems that the recommended Prettier extension for VSCode automatically formats CSS.
I guess this is also true for any editor extension that formats on save.
However ./mach lint is not checking CSS formatting issues, and we have not auto-formatted CSS files in the tree.
This can lead to unexpected formatting changes for developers using VSCode. While we discuss enabling prettier for CSS (:honza filed Bug 1606785), maybe we should just exclude CSS files from prettier's configuration until then?
Assignee | ||
Comment 1•4 years ago
|
||
It seems that the recommended Prettier extension for VSCode automatically formats CSS.
I guess this is also true for any editor extension that formats on save.
However ./mach lint is not checking CSS formatting issues, and we have not auto-formatted CSS files in the tree.
This can lead to unexpected formatting changes for developers using VSCode.
Updated•4 years ago
|
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/421a3f911d73 Exclude CSS files from Prettier configuration r=vporof
Comment 3•4 years ago
|
||
bugherder |
Updated•2 years ago
|
Description
•