1606787 - VSCode prettier extension will automatically format CSS files

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Julian Descottes [:jdescottes]]

Follow up to discussion in https://phabricator.services.mozilla.com/D58476

It seems that the recommended Prettier extension for VSCode automatically formats CSS.
I guess this is also true for any editor extension that formats on save.

However ./mach lint is not checking CSS formatting issues, and we have not auto-formatted CSS files in the tree.

This can lead to unexpected formatting changes for developers using VSCode. While we discuss enabling prettier for CSS (:honza filed Bug 1606785), maybe we should just exclude CSS files from prettier's configuration until then?

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1606787 - Exclude CSS files from Prettier configuration

It seems that the recommended Prettier extension for VSCode automatically formats CSS.
I guess this is also true for any editor extension that formats on save.

However ./mach lint is not checking CSS formatting issues, and we have not auto-formatted CSS files in the tree.

This can lead to unexpected formatting changes for developers using VSCode.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/421a3f911d73
Exclude CSS files from Prettier configuration r=vporof

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/421a3f911d73