1606885 - Text Editing Keyboard Shortcuts Don't Work

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Anna Thewitch]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

I find Firefox for Android very difficult to use both on my software keyboard that has easy access to the control key (messagease) and when I use a bluetooth or other hardware keyboard because text editing shortcuts that work in every other Android application I have tried simply do not function. (It is also extremely frustrating and inconsistent to do the gesture/touchscreen equivalent of these functions, but that is perhaps another issue.)

I frequently use shortcuts such as Ctrl+A for select all, Ctrl+C for copy, Ctrl+V for paste, and Ctrl+X for cut. Also ctrl+backspace does not even do a backspace, let alone delete the previous word. I do not have a physical keyboard handy to test, but this may also happen with things like ctrl/alt plus cursors and the home/end keys for moving the cursor around a body of text.

Actual results:

Keyboard shortcuts do nothing and tend to swallow the input, i.e. ctrl+backspace will not even backspace.

Expected results:

The various standard text editing functions should happen, such as copy, paste, cut, select all, delete last word, move cursor to beginning of paragraph, etc.

Comment 2

[Makoto Kato [:m_kato]]

Keyboard shortcuts do nothing and tend to swallow the input, i.e. ctrl+backspace will not even backspace.

Does Chrome for Android work it well?

Although editbox (and contenteditable) 's keyboard shortcut is defined in https://searchfox.org/mozilla-central/source/dom/events/android/ShortcutKeyDefinitions.cpp, we can add it if it is assigned in Chrome (and/or Android's standard editbox).

Bug 1417352 is browser level shortcut (ctrl+l should be handled by browser, not Gecko).

Comment 3

[Anna Thewitch]

Yes it works fine in Chrome and any other Android application I've ever used with textareas or editable text boxes.

Comment 4

[Makoto Kato [:m_kato]]

https://android.googlesource.com/platform/frameworks/base/+/f2b233d44c796ceab3048a0130682fb5da3db557

commit f2b233d44c796ceab3048a0130682fb5da3db557
Author: Seigo Nonaka <[e-mail]>
Date:   Tue Apr 7 21:02:13 2015 +0900

    Introduce Ctrl+Backspace/Ctrl+ForwardDelete shortcut.

    Ctrl+Backspace deletes preceding one word and Ctrl+ForwardDelete delets
    following one word.
    Used Chrome's implementation/behvior as a reference.

    Bug: 17810742
    Change-Id: I7b2ca515b2f017e457f7104ec7b8e7473ca4e081

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

P3 for now.
hi Chenxia, please feel free to let us know if we should have a higher priority for this issue for android, from your team's point of view.

Comment 6

[Chenxia Liu [:liuche]]

Thanks for the heads up! We will be replacing Fennec (the current Firefox for Android in the Google Play Store) and are currently focusing all our efforts on Firefox Preview. If you find this is also a problem on Firefox Preview, please file a bug in our repo: https://github.com/mozilla-mobile/fenix

Thank you!

Comment 7

[Makoto Kato [:m_kato]]

Attachment: Bug 1606885 - Add control+backspace/delete shortcut.

According to [*1], Android's text control now supports ctrl+backspace and
ctrl+delete shortcut. So we should support it since Chrome already have this.

*1 https://android.googlesource.com/platform/frameworks/base/+/f2b233d44c796ceab3048a0130682fb5da3db557

Comment 8

[Anna Thewitch]

Note that Firefox Preview does not work with text editing shortcuts, either

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a409305a3d8a
Add control+backspace/delete shortcut. r=geckoview-reviewers,snorp

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a409305a3d8a