Closed Bug 1607023 Opened 4 years ago Closed 4 years ago

Remove dead GroupBookmark code

Categories

(SeaMonkey :: Tabbed Browser, task)

Product:
SeaMonkey
Component:
Tabbed Browser
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.53 fixed, seamonkey2.57esr fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey 2.71
Tracking Flags:
Tracking Status
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.2)

Attachments

(1 file, 2 obsolete files)

Remove dead code v1.2
12.17 KB, patch
iannbugzilla
: review+
iannbugzilla
: approval-comm-release+
iannbugzilla
: approval-comm-esr60+
Details | Diff | Splinter Review

The function, openGroupBookmark, that made use of loadGroup, replaceGroup, appendGroup, goBackGroup, goForward and browser.tabs.loadGroup was removed around the time of SM 2.1/2.2 so we should get rid of that code that is no longer used in tabbrowser.xml

Attached patch Remove dead code (obsolete) — — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): 580660 and 580663
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.2
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: removal of 5 strings

Attachment #9118660 - Flags: review?(frgrahl)
Attachment #9118660 - Flags: approval-comm-release?
Attachment #9118660 - Flags: approval-comm-esr60?
Depends on: 1607025
Blocks: 1607041
Comment on attachment 9118660 [details] [diff] [review]
Remove dead code

List in Go Back and Forward button no longer works.

Timestamp: 1/6/2020, 3:43:45 PM
Error: TypeError: gBrowser.backBrowserGroup is undefined
Source File: chrome://navigator/content/navigator.js
Line: 1409

Timestamp: 1/6/2020, 3:44:41 PM
Error: TypeError: gBrowser.forwardBrowserGroup is undefined
Source File: chrome://navigator/content/navigator.js
Line: 1419
Attachment #9118660 - Flags: review?(frgrahl)
Attachment #9118660 - Flags: review-
Attachment #9118660 - Flags: approval-comm-release?
Attachment #9118660 - Flags: approval-comm-release-
Attachment #9118660 - Flags: approval-comm-esr60?
Attachment #9118660 - Flags: approval-comm-esr60-
Attached patch Remove dead code v1.1 (obsolete) — — Splinter Review

Removed some more code I'd missed

Attachment #9118660 - Attachment is obsolete: true
Attachment #9118848 - Flags: review?(frgrahl)
Attachment #9118848 - Flags: approval-comm-release?
Attachment #9118848 - Flags: approval-comm-esr60?
Blocks: 625114
Comment on attachment 9118848 [details] [diff] [review]
Remove dead code v1.1

lgtm
Attachment #9118848 - Flags: review?(frgrahl)
Attachment #9118848 - Flags: review+
Attachment #9118848 - Flags: approval-comm-release?
Attachment #9118848 - Flags: approval-comm-release+
Attachment #9118848 - Flags: approval-comm-esr60?
Attachment #9118848 - Flags: approval-comm-esr60+

Forgot to remove the outdated pref section in help, carrying forward r+/a+

Attachment #9118848 - Attachment is obsolete: true
Attachment #9124521 - Flags: review+
Attachment #9124521 - Flags: approval-comm-release+
Attachment #9124521 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/92b874862cac
Remove dead GroupBookmark code. r=frg

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.71
status-seamonkey2.53: --- → fixed
status-seamonkey2.57esr: --- → fixed
Whiteboard: SM2.53.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: