1607172 - Use ESLint's new ignorePatterns configuration option to ignore paths from ThirdPartyPaths.txt

Status: RESOLVED FIXED

(Firefox Build System :: Lint and Formatting, task, P2)

Description

[Mark Banner (:standard8)]

In ESLint 6.7.0, ESLint added an ignorePatterns configuration option.

This allows us to set ignorePatterns in the top-level .eslintrc.js. As this is a node file, we can read the list from ThirdPartyPaths.txt to get a list of the third-party directories to ignore.

We can then simplify .eslintignore down to just the directories we don't want to lint (node_modules, crashtests etc), and the unlintables (preprocessed files etc).

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1607172 - Update ESLint to the latest version and use ignorePatterns to ignore paths listed in ThirdPartyPaths.txt. r?Mossop

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1607172 - Move devtools third-party entries across to ThirdPartyPaths.txt, and clean up .eslintignore for devtools. r?jdescottes

Depends on D59691

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1607172 - Automatically fix ESLint issues in non-third party dom/media/webvtt/ files. r?jya

Depends on D59692

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1607172 - Move dom third-party entries across to ThirdPartyPaths.txt, and clean up .eslintignore for dom. r?jya

Depends on D59693

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20aa5934c785
Update ESLint to the latest version and use ignorePatterns to ignore paths listed in ThirdPartyPaths.txt. r=mossop
https://hg.mozilla.org/integration/autoland/rev/99ce7a56080e
Move devtools third-party entries across to ThirdPartyPaths.txt, and clean up .eslintignore for devtools. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/93023b1b6153
Automatically fix ESLint issues in non-third party dom/media/webvtt/ files. r=jya
https://hg.mozilla.org/integration/autoland/rev/d69d6dfdccad
Move dom third-party entries across to ThirdPartyPaths.txt, and clean up .eslintignore for dom. r=jya

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e3a24d5378f
Backed out 9 changesets (bug 1607172, bug 1609998, bug 1608799) for causing xpcshell failures in test_parser.js

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1828d488ee8
Update ESLint to the latest version and use ignorePatterns to ignore paths listed in ThirdPartyPaths.txt. r=mossop
https://hg.mozilla.org/integration/autoland/rev/b595c6a105ab
Move devtools third-party entries across to ThirdPartyPaths.txt, and clean up .eslintignore for devtools. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/0c14f3e3dab1
Automatically fix ESLint issues in non-third party dom/media/webvtt/ files. r=jya
https://hg.mozilla.org/integration/autoland/rev/62a823fb3aac
Move dom third-party entries across to ThirdPartyPaths.txt, and clean up .eslintignore for dom. r=jya

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/f1828d488ee8
https://hg.mozilla.org/mozilla-central/rev/b595c6a105ab
https://hg.mozilla.org/mozilla-central/rev/0c14f3e3dab1
https://hg.mozilla.org/mozilla-central/rev/62a823fb3aac