Closed Bug 1609998 Opened 5 years ago Closed 5 years ago

Enable ESLint for non-third party files in editor/libeditor/tests/browserscope/

Categories

(Core :: DOM: Editor, task)

Product:
Core
Component:
DOM: Editor
Type:
task
Priority:
Not set
Severity:
normal
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Iteration:
74.2 - Jan 20 - Feb 09
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Bug 1609998 - Enable ESLint for non-third party files in editor/libeditor/tests/browserscope/. r?m_kato
47 bytes, text/x-phabricator-request
Details | Review

According to ThirdPartyPaths.txt, these two paths are third-party:

editor/libeditor/tests/browserscope/lib/richtext/
editor/libeditor/tests/browserscope/lib/richtext2/

However, .eslintignore is ignoring editor/libeditor/tests/browserscope/.

I am currently moving the third-party paths out of .eslintignore as we can now read them automatically from ThirdPartyPaths.txt (bug 1607172).

Therefore I'd like to drop the more general ESlint exclusion in favour of the existing ones in third party paths.

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7753083b67dd Enable ESLint for non-third party files in editor/libeditor/tests/browserscope/. r=m_kato
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1fb73d26a4f9 Enable ESLint for non-third party files in editor/libeditor/tests/browserscope/. r=m_kato

https://hg.mozilla.org/mozilla-central/rev/1fb73d26a4f9

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: