1607470 - virtualenvs broken by referencing non-virtualenv python executable on macos, mach doc, __PYVENV_LAUNCHER__

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Axel Hecht [:Pike]]

Right now I'm stuck trying to get mach doc to launch.

I've drilled down to __PYVENV_LAUNCHER__ being set to /usr/local/bin/python3 being the culprit when we subprocess out to pip.

Probably the sanest fix is to pass a dedicated environment?

https://stackoverflow.com/questions/26323852/whats-the-meaning-of-pyvenv-launcher-environment-variable links to a couple of other notable posts.

Marking as mach-busted, as I think it is.

Comment 1

[Māris Fogels [:mars] (please needinfo)]

Possibly related: bug 1601578

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Pike, what's the symptom / error messages that you're seeing? I'm having issues doing mach build which I suspect could be related to this, and I'd love to understand more.

Comment 3

[Axel Hecht [:Pike]]

Attachment: ./mach doc output

This is the output I get, the trigger is that pipenv install fails to execute pipenv, as it does so in a python interpreter that's not the virtualenv one, per the leading #!

Comment 4

[Axel Hecht [:Pike]]

Attachment: Bug 1607470, unset __PYVENV_LAUNCHER__ for virtualenvs, r=#build

The PYVENV_LAUNCHER is set on macos to indicate which
python to use. Sadly, keeping this set confuses pip in
virtualenvs.
This corresponds to https://github.com/python/cpython/pull/9516.

Comment 5

[Axel Hecht [:Pike]]

dmose, does this patch improve things for you?

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

I ended up figuring out that my particular problem had something to do with the way my homebrew setup had evolved, and no amount of uninstalling and reinstalling various versions of python would fix it. I finally simply uninstalled homebrew entirely and started over. That fixed my problem. :-/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed91bca1f4a6
unset __PYVENV_LAUNCHER__ for virtualenvs, r=firefox-build-system-reviewers,rstewart

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ed91bca1f4a6