1607557 - "About Firefox" dialog is spread over too many lines

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[Tim Nguyen :ntim]

Attachment: Screenshot

This rule fixes it:

description,
label {
  display: -moz-inline-box;
}

It could be added here: https://searchfox.org/mozilla-central/rev/a92ed79b0bc746159fc31af1586adbfa9e45e264/toolkit/content/xul.css#111

Comment 1

[:Gijs (he/him)]

I mean, that proposed CSS change in xul.css would likely re-break other cases where the new layout of the description is actually desired, right?

Do we know why this breaks with the patch from bug 1606130 ?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Yes, because they're in an HTML block, so block-level elements (read: -moz-box, now) are in a new line by default.

<label> and <description> sounds like the kind of elements that may want to be inline-by-default. They're the only two cases for which I had to change a11y expectations in bug 1606130, too...

Comment 3

[Emilio Cobos Álvarez (:emilio)]

We should probably make the selector a bit more targeted, unless we see other label / description regressions.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1607557 - Make labels and button inline level. r=gijs

<xul:description> doesn't respect display and effectively behaves like
display: flow-root unless it has the value attribute.

<xul:label> and <xul:button> are expected to be inline level when in HTML
blocks.

The former fixes the about dialog (and undoes the a11y changes I had to do in
the regressing bug). The later fixes the session restore page, which in today's
nightly shows the two buttons in different lines.

I could try to write more targeted fixes if you want, and probably switching to
html layout while at it.

<label> can be display: inline, at least in the about dialog. And the
<xul:button> in the restore session page can be <html:buttons> (inline-blocks).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6378942bfb04
Make labels and button inline level. r=Gijs

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/6378942bfb04

Comment 11

[Patrick (he/him)]

Managed to reproduce the issue on an affected build (74.0a1 (2020-01-08), buildid 20200108094158).

The issue is no longer reproducible on Firefox 74.0a1 (2020-01-08), buildid 20200108215606).

Comment 12

[nayinain]

Attachment: Screenshots_200110_12-38-48.png

I can still see similar issues in about:preferences and pop-up notification.

Comment 13

[Tim Nguyen :ntim]

(In reply to nayinain from comment #12)

I can still see similar issues in about:preferences and pop-up notification.

That's bug 1608159.

Comment 14

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Hi,

I've tested this using the latest Nightly version 74.0a1 (2020-01-10) (64-bit) build ID 20200 110095023 for Ubuntu 18.04.3 LTS and Windows 10 pro
and issue is not reproducible anymore. Based on this I will mark firefox74 flag as verified.

Best,
Clara