1607573 - Use GetEmbedderElement for GetRealFrameElementOuter

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P2)

Comment 1

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: Bug 1607573 - Part 1: Change GetRealFrameElementOuter to use BrowsingContext,

This does not fix consumers of GetRealFrameElementOuter, which may still act
incorrectly, as the frame element will not be available in cross-process
situations, but removes a user of the docshell tree.

This has a small behaviour change, in that it causes 'window.realFrameElement'
to return 'null' when run within an <iframe mozbrowser>. A quick inspection of
use-sites suggested that this would not be an issue, and it appears to pass a
try run.

Comment 2

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: Bug 1607573 - Part 2: Remove nsPIDOMWindowInner::GetFrameElement,

Comment 3

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: Bug 1607573 - Part 3: Remove GetRealFrameElementOuter in favor of GetFrameElement,

Comment 4

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: Bug 1607573 - Part 4: Drop the 'Outer' from GetFrameElementOuter,

No longer necessary since the nsGlobalWindow{Inner,Outer}-split.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7180d7d7db1
Part 1: Change GetRealFrameElementOuter to use BrowsingContext, r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/41af912c9387
Part 2: Remove nsPIDOMWindowInner::GetFrameElement, r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/4342a6fd2c69
Part 3: Remove GetRealFrameElementOuter in favor of GetFrameElement, r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/4329a22210f5
Part 4: Drop the 'Outer' from GetFrameElementOuter, r=bzbarsky

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b7180d7d7db1
https://hg.mozilla.org/mozilla-central/rev/41af912c9387
https://hg.mozilla.org/mozilla-central/rev/4342a6fd2c69
https://hg.mozilla.org/mozilla-central/rev/4329a22210f5