1607696 - Update to Django 2

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P2)

Description

[Matjaz Horvat [:mathjazz]]

Django 1.11 LTS reaches end of extended support in April 2020:
https://www.djangoproject.com/download/

We should upgrade to Django 2.2 LTS, and afterwards possibly to 3.0.

Note that the on_delete argument for ForeignKey and OneToOneField is now required in models and migrations. We could use the Django update as an opportunity to make deleting user accounts easier by setting on_delete=models.SET_NULL on the User ForeignKeys. See bug 1561663 for more details.

Comment 1

[Jarek Śmiejczak [:jotes]]

As We discussed at All Hands Brrlin, I'll write a small spec to make this migration smooth.

Comment 2

[Jarek Śmiejczak [:jotes]]

Hey everyone,

Here's a very short-term plan about the migration to Django 2.2.
I don't know if all of these points can be mapped into separate bugs (?) and how many pull requests this will take.

I'll start with things that shouldn't break the existing code:

• Make all Pontoon's middlewares compatible with Django 2.2
• Update all urls to use simplified routing
  • https://docs.djangoproject.com/en/3.0/releases/2.0/#simplified-url-routing-syntax
• Update the models
  • explicitly set on_delete attribute on foreign keys and one-to-one fields
  • check the ordering attribute against https://docs.djangoproject.com/en/3.0/releases/2.2/#model-meta-ordering-will-no-longer-affect-group-by-queries
• Check if the current dependencies support Django 3 and bump their versions up if needed:
  • pytest-django
  • django-debug-toolbar
  • django-extensions
  • django-sslserver
  • django-model-utils
  • django-ace
  • django-allauth
  • django-bmemcached
  • django-bulk-update
  • django-cors-headers
  • django_csp
  • django-dirtyfields
  • django-dotenv
  • django_guardian
  • django-jinja
  • django-nose
  • django-notifications-hq
  • django-partial-index
  • django-pipeline
  • django-cookies-samesite
  • django-session-csrf
  • django-webpack-loader
  • graphene-django

After that, We can prepare a PR which will finish the migration:

• Update Pontoon to use Django 2.2
• Set (SESSION|CSRF)_COOKIE_SAMESITE and remove the django-cookies-samesite from the list of the dependencies
• Fix unittests if they fail on Django 2.2
• Check the sync (:mathjazz / :adrian, I'll need help with that)

Additional questions:

• :adrian, :mathjazz: Do we want to squash existing migrations?

Comment 3

[Matjaz Horvat [:mathjazz]]

Thanks for the update, jotes!

I don't have strong opinions here, so I'll leave the decision about squashing migrations to Adrian.

Comment 4

[Axel Hecht [:Pike]]

You'll need to squash migrations, as Django 2.x will refuse to start if you have old migrations w/out on_delete. So that needs to happen after the change to the models, but before you get off of 1.11.

Clearing NI on Adrian, as there's no choice.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1567

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

adngdb merged PR #1567: "Bug 1607696 - Migrate middlewares to Django 2.0 and replace `django.c…" in c1a9db2.

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1576

Comment 8

[Matjaz Horvat [:mathjazz]]

Once on Django 2/3, we should update django-allauth to the latest version:
https://github.com/mozilla/pontoon/pull/1588#issuecomment-599763118

Comment 9

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1591

Comment 10

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1605

Comment 11

[Matjaz Horvat [:mathjazz]]

Let's continue the upgrade process under bug 1627655.