1627655 - Update to Django 3.x

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P3)

Description

[Matjaz Horvat [:mathjazz]]

'nuff said.

Comment 1

[Axel Hecht [:Pike]]

A few notes from https://www.djangoproject.com/download/#supported-versions.

2.2 is on LTS until April 2022, oth, 3.0 only gets us into April 2021, so a year less. The next LTS is 3.2, which releases April 2021.

If there are features in 3.0 for Pontoon, we should do this. Otherwise, this might have some time.

Comment 2

[Matjaz Horvat [:mathjazz]]

We've decided not to upgrade to Django 3.0 at this stage, since there are no features in 3.0 we need in Pontoon at this stage.

Comment 3

[Philipp Fischbeck]

In the meantime, Django 3.1 was released: https://docs.djangoproject.com/en/3.1/releases/3.1/
It will be supported until December 2021: https://www.djangoproject.com/download/#supported-versions

I understand if this is not a priority for you, but I am interested in working on the upgrade (including the package upgrades needed for that). Would you accept pull requests related to this?

I think the code quality could benefit from the upgrade, e.g., the new enumeration types could vastly improve the readability and maintainability of the ActionLog class.

What do you think?

Comment 4

[Jarek Śmiejczak [:jotes]]

Hey,
:mathjazz is the maintainer of the project, but I was also working on the various "migration-like" tasks in the past and I have a few thoughts and notes (written as I would talk to my past self):

• analyze the release notes, start from looking at the backward incompabilities
• create a plan of the migration and split the changes into smaller pull requests. Mostly for the sake of reviewability and quality assurance and communication
• go through all of the depedencies, check their supported Django versions and update when needed
• don't mix up code refactorings with the things that are critical to the update Django

About enums: I also think they could potentially increase the maintaintability. We had discussion about them in the past but we decided to not use use them, because they required additional dependency back then. I think it's worth doing, in a separate bug though.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1697

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1699

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1705

Comment 8

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1709

Comment 9

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1710

Comment 10

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1712

Comment 11

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1714

Comment 12

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1718

Comment 13

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1719

Comment 14

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1736

Comment 15

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1738

Comment 16

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1740

Comment 17

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1745