Closed
Bug 1607718
Opened 6 years ago
Closed 6 years ago
Make setTabAttributes and updateTabPosition private methods
Categories
(Firefox :: Tabbed Browser, task, P3)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: dao, Assigned: emmamalysz)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
From briefly looking at bug 1242912's patch, it looks like setTabAttributes and updateTabPosition should be private (i.e. prefixed with underscore) as we don't expect them to be called from outside the tabbrowser object; they're not part of the API we want to provide to code interacting with tabbrowser.
Emma, can you take this?
Flags: needinfo?(emalysz)
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → emalysz
Flags: needinfo?(emalysz)
|
|
Assignee | |
Comment 1•6 years ago
|
||
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d405a9f7d93f
make addTab helper methods private r=dao
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
You need to log in
before you can comment on or make changes to this bug.
Description
•