Closed
Bug 1610463
Opened 6 years ago
Closed 6 years ago
Move _setTabAttributes back into addTab
Categories
(Firefox :: Tabbed Browser, task, P2)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: dao, Assigned: emmamalysz)
References
Details
Attachments
(1 file)
Following up from bug 1607718, _setTabAttributes should be renamed as it calls _unlockTabSizing and _handleNewTab besides setting attributes. Alternatively, we should get rid of this method and move this code back into addTab.
Flags: needinfo?(emalysz)
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Updated•6 years ago
|
Assignee: nobody → emalysz
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•6 years ago
|
Flags: needinfo?(emalysz)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c36ea2be8f87
move _setTabAttributes back into addTab because it was incorrectly named r=dao
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
|
Reporter | |
Updated•6 years ago
|
Summary: Rename _setTabAttributes to match what it actually does → Move _setTabAttributes back into addTab
You need to log in
before you can comment on or make changes to this bug.
Description
•