Closed Bug 1607741 Opened 3 years ago Closed 2 years ago

Remove the cd command

Categories

(DevTools :: Console, task, P3)

Product:
DevTools
Component:
Console
Type:
task

Tracking

(Fission Milestone:M7, firefox86 fixed)

Status:
RESOLVED FIXED
Milestone:
86 Branch
Project Flags:
Fission Milestone M7
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

(Keywords: dev-doc-complete, Whiteboard: dt-fission-m3-mvp)

Attachments

(1 file)

Bug 1607741 - [devtools] Remove webconsole cd command. r=ladybenko.
48 bytes, text/x-phabricator-request
Details | Review

Once the context picker is added to the console UI, there's no reason to support the cd command anymore

Tracking DevTools bugs for Fission Nightly (M6) milestone

Fission Milestone: --- → M6

Looks like the docs under https://developer.mozilla.org/en-US/docs/Tools/Web_Console/Helpers need to be updated once this command got removed.

Sebastian

Keywords: dev-doc-needed

Should this be blocked on enabling the context selector in both Browser Toolbox and Content Toolbox in all channels?

Flags: needinfo?(nchevobbe)

(In reply to Julian Descottes [:jdescottes] from comment #3)

Should this be blocked on enabling the context selector in both Browser Toolbox and Content Toolbox in all channels?

Yes.
I even wonder if we shouldn't block on "create target for every frame"; the cd command would change the context if you cd'd in a same-origin iframe. I'm not sure we have a clear plan for such thing yet?

Depends on: 1605330
Flags: needinfo?(nchevobbe)

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)

Fission Milestone: M6 → M6c
Priority: P2 → P3
Whiteboard: dt-fission-m2-mvp → dt-fission-m2-reserve
Fission Milestone: M6c → Future
Whiteboard: dt-fission-m2-reserve → dt-fission-m3-mvp

The command is removed and the test that were using it
are either removed or updated.

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe0357d59bfd
[devtools] Remove webconsole cd command. r=ladybenko.

https://hg.mozilla.org/mozilla-central/rev/fe0357d59bfd

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch

FYI this has been documented for FF86. Primarily that means removal of the cd command from the "Web console helper" doc and the JavaScript interpreter doc, and addition of a release note.

Full details of docs changes can be found in mdn/content#1729

This completed dt-fission-m3-mvp bug should have Fission Milestone M7 Beta.

Fission Milestone: Future → M7
You need to log in before you can comment on or make changes to this bug.