1605330 - Enable Context Selector in Nightly

Status: RESOLVED FIXED

(DevTools :: Framework, task, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Let's enable the Context Selector for Nightly users when ready for testing.

Pref:
devtools.webconsole.input.context

Honza

Comment 1

[Jason Laster [:jlast]]

Attachment: Bug 1605330 - Enable Context Selector in Nightly. r=nchevobbe

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Let's block this one on the following for now

• Worker support
• Remote frame support

We can reevaluate when one of those is ready (the support for remote frames might be done first)

Honza

Comment 3

[Alexandre Poirot [:ochameau]]

Bug 1593937 is going to help keep the list of frame target up to date. Otherwise, the selector would only show already existing targets, and not the one created after the toolbox is opened.
So we should probably review the state of the selector after bug 1593937 is landed. This might highlight some other limitation.

Regarding workers, we could as well decide that we do not care about displaying workers yet?
In this case, it means that we should probably introduce another preference in bug 1592584 so that we enable worker targets in content toolbox only once everything works great around them.

Finally, we might want to block on bug 1602748. Otherwise, we would only display remote frames in the selector. i.e. frames which are loaded in a distinct process from their parent document. i.e. frame using a distinct domain from their parent document. Bug 1602748 is only about introducing a preference, this will most likely require more work before being enable to turn this on by default and depends on completing M2 milestone.

Comment 4

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

(moving to reserve as it's not critical for fission m2 and we might need the slot for mvp work)

Comment 6

[Neha Kochar [:neha]]

Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.

Comment 7

[Chris Peterson [:cpeterson]]

Moving "dt-fission-m3-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1605330 - [devtools] Enable context selector on Nightly. r=ochameau.

We take this opportunity to merge the browser toolbox and content toolbox preferences
into a single one.

Depends on D131600

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe65ddb40037
[devtools] Enable context selector on Nightly. r=ochameau.

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fe65ddb40037

Comment 12

[Cristian Tuns]

Backed out for causing damp failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | damp | inspector/custom.js: Test timed out

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56f96e016e98
[devtools] Enable context selector on Nightly. r=ochameau.

Comment 14

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/56f96e016e98

Comment 15

[Chris Peterson [:cpeterson]]

Setting status-firefox95=wontfix because we don't need to uplift the Context Selector to Beta 95.